Issue 14608004: Move instant support to SearchTabHelper. Fix InstantTab reset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14608004: Move instant support to SearchTabHelper. Fix InstantTab reset. (Closed)

Created:
7 years, 7 months ago by samarth

Modified:
7 years, 7 months ago

Reviewers:

CC:
chromium-reviews, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, sreeram, gideonwald, dominich, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move instant support to SearchTabHelper. Fix InstantTab reset. BUG=

Patch Set 1 #

Patch Set 2 : Fix typo. #

Patch Set 3 : Guard instant-extended-only bits. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -31 lines)			Patch
M	chrome/browser/ui/search/instant_controller.cc	View		3 chunks	+23 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/search/instant_page.h	View		4 chunks	+14 lines, -1 line	0 comments	Download
M	chrome/browser/ui/search/instant_page.cc	View	1 2	8 chunks	+52 lines, -16 lines	0 comments	Download
M	chrome/browser/ui/search/instant_tab.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/search/search_model.h	View	1	3 chunks	+24 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/search/search_model.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/search/search_tab_helper.h	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/search/search_tab_helper.cc	View		4 chunks	+24 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

samarth

What do you think of this approach for fixing the instant tab resetting issue? If ...

7 years, 7 months ago (2013-05-04 15:35:39 UTC) #1

sreeram

As discussed over email, let's postpone this to after the branch.

7 years, 7 months ago (2013-05-05 17:40:38 UTC) #2

sreeram

7 years, 7 months ago (2013-05-13 22:12:48 UTC) #3

Removing myself as reviewer. @kmadhusu has taken over this CL in
https://codereview.chromium.org/14911005/, so this can be closed, I think.

Expand Messages | Collapse Messages