Fix protocol for aborting and waiting for cancelable tasks.

src/cancelable-task.cc

Index: src/cancelable-task.cc
diff --git a/src/cancelable-task.cc b/src/cancelable-task.cc
index a2f344d39fc5b9ef699c0c43bca98ad7d7a53748..7f54aa70d4a0e25fcdac61f8df50f80b6e284972 100644
--- a/src/cancelable-task.cc
+++ b/src/cancelable-task.cc
@@ -23,7 +23,7 @@ Cancelable::~Cancelable() {
   // manager object. This happens when the manager cancels all pending tasks
   // in {CancelAndWait} only before destroying the manager object.
   if (TryRun() || IsRunning()) {
-    parent_->TryAbort(id_);
+    parent_->RemoveFinishedTask(id_);
   }
 }
 
@@ -50,15 +50,29 @@ uint32_t CancelableTaskManager::Register(Cancelable* task) {
 }
 
 
+void CancelableTaskManager::RemoveFinishedTask(uint32_t id) {
+  base::LockGuard<base::Mutex> guard(&mutex_);
+  void* removed = cancelable_tasks_.Remove(reinterpret_cast<void*>(id), id);
+  USE(removed);
+  CHECK(removed != nullptr);

[Hannes Payer (out of office), 2015/11/19 14:19:07]

DCHECK

[Michael Lippautz, 2015/11/19 14:20:30]

Done.

+  cancelable_tasks_barrier_.NotifyOne();
+}
+
+
 bool CancelableTaskManager::TryAbort(uint32_t id) {
   base::LockGuard<base::Mutex> guard(&mutex_);
-  Cancelable* value = reinterpret_cast<Cancelable*>(
-      cancelable_tasks_.Remove(reinterpret_cast<void*>(id), id));
-  if (value != nullptr) {
-    bool success = value->Cancel();
-    cancelable_tasks_barrier_.NotifyOne();
-    if (!success) return false;
-    return true;
+  HashMap::Entry* entry =
+      cancelable_tasks_.Lookup(reinterpret_cast<void*>(id), id);
+  if (entry != nullptr) {
+    Cancelable* value = reinterpret_cast<Cancelable*>(entry->value);
+    if (value->Cancel()) {
+      // Cannot call RemoveFinishedTask here because of recursive locking.
+      void* removed = cancelable_tasks_.Remove(reinterpret_cast<void*>(id), id);
+      USE(removed);
+      CHECK(removed != nullptr);

[Hannes Payer (out of office), 2015/11/19 14:19:07]

DCHECK

[Michael Lippautz, 2015/11/19 14:20:30]

Done.

+      cancelable_tasks_barrier_.NotifyOne();
+      return true;
+    }
   }
   return false;
 }