Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1460763003: Fix libvpx's gyp for enabling AVX instructions with MSVC and clang-cl (Closed)

Created:
5 years, 1 month ago by Reid Kleckner
Modified:
5 years, 1 month ago
Reviewers:
hans, Johann, Tom Finegan
CC:
chromium-reviews, wwcv, jzern, fgalligan1, Tom Finegan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix libvpx's gyp for enabling AVX instructions with MSVC and clang-cl The correct enum value for AVX is 3, not 4. The enum value of 4 implies /arch:IA32, which means x87 FPU ops only. R=johannkoenig@google.com,tomfinegan@chromium.org,hans@chromium.org BUG=557968 Committed: https://crrev.com/3ee81c7e4cd918089b93b144024b717168f43f2c Cr-Commit-Position: refs/heads/master@{#360455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/libvpx_new/generate_gypi.sh View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx_new/libvpx_srcs_x86_64_intrinsics.gypi View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx_new/libvpx_srcs_x86_intrinsics.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Reid Kleckner
5 years, 1 month ago (2015-11-18 22:34:38 UTC) #1
hans
LGTM
5 years, 1 month ago (2015-11-18 22:36:06 UTC) #2
Johann
LGTM. Apologies, I just looked at https://msdn.microsoft.com/en-us/library/7t5yh4fd.aspx and made as assumption.
5 years, 1 month ago (2015-11-18 22:36:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460763003/1
5 years, 1 month ago (2015-11-18 22:38:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 00:38:40 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 00:40:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ee81c7e4cd918089b93b144024b717168f43f2c
Cr-Commit-Position: refs/heads/master@{#360455}

Powered by Google App Engine
This is Rietveld 408576698