Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1460763002: Changes analyzer to include test_targets in compile_targets (Closed)

Created:
5 years, 1 month ago by sky
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Changes analyzer to include test_targets in compile_targets In order to run test_targets we have to make sure they are actually built. BUG=557505 TEST=covered by tests R=dpranke@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/e1133480da78cd4a23a8cec604d1d6d46dab35d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M pylib/gyp/generator/analyzer.py View 2 chunks +5 lines, -2 lines 0 comments Download
M test/analyzer/gyptest-analyzer.py View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
I didn't add new tests as a couple of existing test had to be updated, ...
5 years, 1 month ago (2015-11-18 18:11:07 UTC) #1
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-18 18:30:55 UTC) #2
Dirk Pranke
On 2015/11/18 18:30:55, Dirk Pranke wrote: > lgtm Thinking about this a bit more, it ...
5 years, 1 month ago (2015-11-18 19:59:12 UTC) #3
sky
On 2015/11/18 19:59:12, Dirk Pranke wrote: > On 2015/11/18 18:30:55, Dirk Pranke wrote: > > ...
5 years, 1 month ago (2015-11-18 21:06:27 UTC) #4
Dirk Pranke
On 2015/11/18 21:06:27, sky wrote: > I think you're right. I'm inclined to go with ...
5 years, 1 month ago (2015-11-18 21:11:56 UTC) #5
sky
5 years, 1 month ago (2015-11-18 21:29:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e1133480da78cd4a23a8cec604d1d6d46dab35d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698