Changes analyzer to include test_targets in compile_targets

Changes analyzer to include test_targets in compile_targets

In order to run test_targets we have to make sure they are actually
built.

BUG=557505
TEST=covered by tests
R=dpranke@chromium.org

Committed: https://chromium.googlesource.com/external/gyp/+/e1133480da78cd4a23a8cec604d1d6d46dab35d6

[sky, 2015-11-18 18:11:07]

I didn't add new tests as a couple of existing test had to be updated, which
gives us coverage.

[Dirk Pranke, 2015-11-18 18:30:55]

lgtm

[Dirk Pranke, 2015-11-18 19:59:12]

On 2015/11/18 18:30:55, Dirk Pranke wrote:
> lgtm

Thinking about this a bit more, it seems like we could potentially do better
than this, by checking
to see if any of the test_targets are already dependencies of stuff in
compile_targets, though
I'm not sure how often this would come up in practice ...

[sky, 2015-11-18 21:06:27]

On 2015/11/18 19:59:12, Dirk Pranke wrote:
> On 2015/11/18 18:30:55, Dirk Pranke wrote:
> > lgtm
> 
> Thinking about this a bit more, it seems like we could potentially do better
> than this, by checking
> to see if any of the test_targets are already dependencies of stuff in
> compile_targets, though
> I'm not sure how often this would come up in practice ...

I think you're right. I'm inclined to go with this fix for now though. You ok
with that?

[Dirk Pranke, 2015-11-18 21:11:56]

On 2015/11/18 21:06:27, sky wrote:
> I think you're right. I'm inclined to go with this fix for now though. You ok
> with that?

Yes, sorry if that wasn't clear.

[sky, 2015-11-18 21:29:45]

Committed patchset #1 (id:1) manually as
e1133480da78cd4a23a8cec604d1d6d46dab35d6 (presubmit successful).