Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: device/serial/serial_io_handler_win.h

Issue 1460743002: Revert of Reland: Add code to deal with serial device disconnection detection on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/serial/serial_io_handler.cc ('k') | device/serial/serial_io_handler_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/serial/serial_io_handler_win.h
diff --git a/device/serial/serial_io_handler_win.h b/device/serial/serial_io_handler_win.h
index 831eab614048b10a780c56a29ac659336c59f027..7f438b53ae4a83f74252bfe6013407d625da4a76 100644
--- a/device/serial/serial_io_handler_win.h
+++ b/device/serial/serial_io_handler_win.h
@@ -32,7 +32,6 @@
bool PostOpen() override;
private:
- class UiThreadHelper;
friend class SerialIoHandler;
explicit SerialIoHandlerWin(
@@ -44,8 +43,6 @@
void OnIOCompleted(base::MessageLoopForIO::IOContext* context,
DWORD bytes_transfered,
DWORD error) override;
-
- void OnDeviceRemoved(const std::string& device_path);
// Context used for asynchronous WaitCommEvent calls.
scoped_ptr<base::MessageLoopForIO::IOContext> comm_context_;
@@ -64,11 +61,6 @@
// after a corresponding WaitCommEvent has completed.
bool is_comm_pending_;
- // The helper lives on the UI thread and holds a weak reference back to the
- // handler that owns it.
- UiThreadHelper* helper_ = nullptr;
- base::WeakPtrFactory<SerialIoHandlerWin> weak_factory_;
-
DISALLOW_COPY_AND_ASSIGN(SerialIoHandlerWin);
};
« no previous file with comments | « device/serial/serial_io_handler.cc ('k') | device/serial/serial_io_handler_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698