Revert of Bind Application in renderer

Revert of Bind Application in renderer (patchset #14 id:260001 of https://codereview.chromium.org/1452823003/ )

Reason for revert:
Speculatively reverting this, as this CL landed exactly at the time when renderer started crashing on linux_chromium_rel_ng.

Original issue's description:
> Bind Application in renderer.
>
> This involved changing how we get the client handle to the renderer. In the first iteration I was passing this on the command line but that turns out not to work with the sandbox. So instead I an approach used by the Mojo-in-Chrome MojoApplication class and pass the primordial handle via Chrome IPC.
>
> I had to twiddle a bunch of BUILD.gn files in content to get this to work without crashing due to inconsistencies in how MOJO_SHELL_CLIENT was defined.
>
> R=jam@chromium.org,tsepez@chromium.org
> http://crbug.com/551253
>
> Committed: https://crrev.com/3edb97198bc5fbc22c5cf13286e8af80449ddfb9
> Cr-Commit-Position: refs/heads/master@{#360293}

TBR=jam@chromium.org,tsepez@chromium.org,ben@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557732
Committed: https://crrev.com/bf5ac583bf02c0b627f3a9c32798a74c1b83b68b
Cr-Commit-Position: refs/heads/master@{#360331}

[msramek, 2015-11-18 14:55:55]

Created Revert of Bind Application in renderer

[msramek, 2015-11-18 14:56:09]

Description was changed from

==========
Revert of Bind Application in renderer (patchset #14 id:260001 of
https://codereview.chromium.org/1452823003/ )

Reason for revert:
Speculatively reverting this, as this CL landed exactly at the time when
renderer started crashing on linux_chromium_rel_ng.

Original issue's description:
> Bind Application in renderer.
> 
> This involved changing how we get the client handle to the renderer. In the
first iteration I was passing this on the command line but that turns out not to
work with the sandbox. So instead I an approach used by the Mojo-in-Chrome
MojoApplication class and pass the primordial handle via Chrome IPC.
> 
> I had to twiddle a bunch of BUILD.gn files in content to get this to work
without crashing due to inconsistencies in how MOJO_SHELL_CLIENT was defined.
> 
> R=jam@chromium.org,tsepez@chromium.org
> http://crbug.com/551253
> 
> Committed: https://crrev.com/3edb97198bc5fbc22c5cf13286e8af80449ddfb9
> Cr-Commit-Position: refs/heads/master@{#360293}

TBR=jam@chromium.org,tsepez@chromium.org,ben@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Bind Application in renderer (patchset #14 id:260001 of
https://codereview.chromium.org/1452823003/ )

Reason for revert:
Speculatively reverting this, as this CL landed exactly at the time when
renderer started crashing on linux_chromium_rel_ng.

Original issue's description:
> Bind Application in renderer.
> 
> This involved changing how we get the client handle to the renderer. In the
first iteration I was passing this on the command line but that turns out not to
work with the sandbox. So instead I an approach used by the Mojo-in-Chrome
MojoApplication class and pass the primordial handle via Chrome IPC.
> 
> I had to twiddle a bunch of BUILD.gn files in content to get this to work
without crashing due to inconsistencies in how MOJO_SHELL_CLIENT was defined.
> 
> R=jam@chromium.org,tsepez@chromium.org
> http://crbug.com/551253
> 
> Committed: https://crrev.com/3edb97198bc5fbc22c5cf13286e8af80449ddfb9
> Cr-Commit-Position: refs/heads/master@{#360293}

TBR=jam@chromium.org,tsepez@chromium.org,ben@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557732
==========

[msramek, 2015-11-18 14:56:19]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2015-11-18 14:56:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1460713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1460713002/1

[Ben Goodger (Google), 2015-11-18 14:57:36]

do you have a link to build output.?

-Ben

On Wed, Nov 18, 2015 at 6:55 AM, <msramek@chromium.org> wrote:

> Reviewers: jam, Tom Sepez, Ben Goodger (Google)
> CL: https://codereview.chromium.org/1460713002/
>
> Message:
> Created Revert of Bind Application in renderer
>
> Description:
> Revert of Bind Application in renderer (patchset #14 id:260001 of
> https://codereview.chromium.org/1452823003/ )
>
> Reason for revert:
> Speculatively reverting this, as this CL landed exactly at the time when
> renderer started crashing on linux_chromium_rel_ng.
>
> Original issue's description:
>
>> Bind Application in renderer.
>>
>
> This involved changing how we get the client handle to the renderer. In the
>>
> first iteration I was passing this on the command line but that turns out
> not to
> work with the sandbox. So instead I an approach used by the Mojo-in-Chrome
> MojoApplication class and pass the primordial handle via Chrome IPC.
>
> I had to twiddle a bunch of BUILD.gn files in content to get this to work
>>
> without crashing due to inconsistencies in how MOJO_SHELL_CLIENT was
> defined.
>
> R=jam@chromium.org,tsepez@chromium.org
>> http://crbug.com/551253
>>
>
> Committed: https://crrev.com/3edb97198bc5fbc22c5cf13286e8af80449ddfb9
>> Cr-Commit-Position: refs/heads/master@{#360293}
>>
>
> TBR=jam@chromium.org,tsepez@chromium.org,ben@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+116, -250 lines):
>   M components/mus/example/window_type_launcher/main.cc
>   M content/app/BUILD.gn
>   M content/browser/BUILD.gn
>   M content/browser/child_process_launcher.cc
>   D content/browser/mojo/mojo_shell_client_host.h
>   D content/browser/mojo/mojo_shell_client_host.cc
>   M content/browser/renderer_host/render_process_host_impl.cc
>   M content/child/BUILD.gn
>   M content/child/child_thread_impl.h
>   M content/child/child_thread_impl.cc
>   M content/common/BUILD.gn
>   M content/common/mojo/mojo_messages.h
>   M content/common/mojo/mojo_shell_connection_impl.h
>   M content/common/mojo/mojo_shell_connection_impl.cc
>   M content/gpu/BUILD.gn
>   M content/plugin/BUILD.gn
>   M content/ppapi_plugin/BUILD.gn
>   M content/public/browser/BUILD.gn
>   M content/public/common/BUILD.gn
>   M content/public/renderer/BUILD.gn
>   M content/renderer/BUILD.gn
>   M content/test/BUILD.gn
>   M content/utility/BUILD.gn
>   M mojo/runner/child/runner_connection.h
>   M mojo/runner/child/runner_connection.cc
>   M mojo/runner/child/test_native_main.cc
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-11-18 14:57:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-18 14:58:43]

Patchset 1 (id:??) landed as
https://crrev.com/bf5ac583bf02c0b627f3a9c32798a74c1b83b68b
Cr-Commit-Position: refs/heads/master@{#360331}

[msramek, 2015-11-18 14:58:57]

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

See also the attached bug crbug.com/557732

On 2015/11/18 14:57:36, Ben Goodger (Google) wrote:
> do you have a link to build output.?
> 
> -Ben
> 
> On Wed, Nov 18, 2015 at 6:55 AM, <mailto:msramek@chromium.org> wrote:
> 
> > Reviewers: jam, Tom Sepez, Ben Goodger (Google)
> > CL: https://codereview.chromium.org/1460713002/
> >
> > Message:
> > Created Revert of Bind Application in renderer
> >
> > Description:
> > Revert of Bind Application in renderer (patchset #14 id:260001 of
> > https://codereview.chromium.org/1452823003/ )
> >
> > Reason for revert:
> > Speculatively reverting this, as this CL landed exactly at the time when
> > renderer started crashing on linux_chromium_rel_ng.
> >
> > Original issue's description:
> >
> >> Bind Application in renderer.
> >>
> >
> > This involved changing how we get the client handle to the renderer. In the
> >>
> > first iteration I was passing this on the command line but that turns out
> > not to
> > work with the sandbox. So instead I an approach used by the Mojo-in-Chrome
> > MojoApplication class and pass the primordial handle via Chrome IPC.
> >
> > I had to twiddle a bunch of BUILD.gn files in content to get this to work
> >>
> > without crashing due to inconsistencies in how MOJO_SHELL_CLIENT was
> > defined.
> >
> > mailto:R=jam@chromium.org,tsepez@chromium.org
> >> http://crbug.com/551253
> >>
> >
> > Committed: https://crrev.com/3edb97198bc5fbc22c5cf13286e8af80449ddfb9
> >> Cr-Commit-Position: refs/heads/master@{#360293}
> >>
> >
> > mailto:TBR=jam@chromium.org,tsepez@chromium.org,ben@chromium.org
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> >
> > Base URL: https://chromium.googlesource.com/chromium/src.git@master
> >
> > Affected files (+116, -250 lines):
> >   M components/mus/example/window_type_launcher/main.cc
> >   M content/app/BUILD.gn
> >   M content/browser/BUILD.gn
> >   M content/browser/child_process_launcher.cc
> >   D content/browser/mojo/mojo_shell_client_host.h
> >   D content/browser/mojo/mojo_shell_client_host.cc
> >   M content/browser/renderer_host/render_process_host_impl.cc
> >   M content/child/BUILD.gn
> >   M content/child/child_thread_impl.h
> >   M content/child/child_thread_impl.cc
> >   M content/common/BUILD.gn
> >   M content/common/mojo/mojo_messages.h
> >   M content/common/mojo/mojo_shell_connection_impl.h
> >   M content/common/mojo/mojo_shell_connection_impl.cc
> >   M content/gpu/BUILD.gn
> >   M content/plugin/BUILD.gn
> >   M content/ppapi_plugin/BUILD.gn
> >   M content/public/browser/BUILD.gn
> >   M content/public/common/BUILD.gn
> >   M content/public/renderer/BUILD.gn
> >   M content/renderer/BUILD.gn
> >   M content/test/BUILD.gn
> >   M content/utility/BUILD.gn
> >   M mojo/runner/child/runner_connection.h
> >   M mojo/runner/child/runner_connection.cc
> >   M mojo/runner/child/test_native_main.cc
> >
> >
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.