Issue 14607022: Don't pass the -metadata-text argument to llc, since it's not being used any longer.

Issue 14607022: Don't pass the -metadata-text argument to llc, since it's not being used any longer. (Closed)

Created:
7 years, 7 months ago by eliben

Modified:
7 years, 7 months ago

Reviewers:
jvoung (off chromium), Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

Don't pass the -metadata-text argument to llc, since it's not being used any longer. BUG=None R=jvoung@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=11349

Patch Set 2 : Handle build warning #

Patch Set 3 : Remove USE_META-related stuff #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -20 lines)			Patch
	M	pnacl/driver/pnacl-translate.py	View	1 2	5 chunks	+1 line, -20 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jvoung (off chromium)

https://codereview.chromium.org/14607022/diff/1/pnacl/driver/pnacl-translate.py File pnacl/driver/pnacl-translate.py (right): https://codereview.chromium.org/14607022/diff/1/pnacl/driver/pnacl-translate.py#newcode101 pnacl/driver/pnacl-translate.py:101: 'USE_META': '0', Please remove USE_META and bits related to ...

7 years, 7 months ago (2013-05-14 23:48:46 UTC) #2

eliben

7 years, 7 months ago (2013-05-15 15:40:41 UTC) #3

eliben

7 years, 7 months ago (2013-05-15 17:29:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r11349 (presubmit successful).

Expand Messages | Collapse Messages