Issue 14607012: need to clamp all of the cubic points after a chop, in case our finite precision

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14607012: need to clamp all of the cubic points after a chop, in case our finite precision (Closed)

Created:
7 years, 7 months ago by reed1

Modified:
7 years, 7 months ago

Reviewers:
caryclark

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

need to clamp all of the cubic points after a chop, in case our finite precision meant we didn't compute values below the chop-point. crbug:234190 R=caryclark@google.com Committed: https://code.google.com/p/skia/source/detail?r=9071

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	src/core/SkEdgeClipper.cpp	View		1 chunk	+1 line, -0 lines	2 comments	Download
	M	tests/PathTest.cpp	View		2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

caryclark

lgtm https://codereview.chromium.org/14607012/diff/1/src/core/SkEdgeClipper.cpp File src/core/SkEdgeClipper.cpp (right): https://codereview.chromium.org/14607012/diff/1/src/core/SkEdgeClipper.cpp#newcode291 src/core/SkEdgeClipper.cpp:291: clamp_ge(tmp[5].fY, tmp[4].fY); update the comment above?

7 years, 7 months ago (2013-05-08 21:07:35 UTC) #2

reed1

https://codereview.chromium.org/14607012/diff/1/src/core/SkEdgeClipper.cpp File src/core/SkEdgeClipper.cpp (right): https://codereview.chromium.org/14607012/diff/1/src/core/SkEdgeClipper.cpp#newcode291 src/core/SkEdgeClipper.cpp:291: clamp_ge(tmp[5].fY, tmp[4].fY); On 2013/05/08 21:07:35, caryclark wrote: > update ...

7 years, 7 months ago (2013-05-08 21:08:03 UTC) #3

reed1

7 years, 7 months ago (2013-05-08 21:08:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r9071 (presubmit successful).

Expand Messages | Collapse Messages