Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 14607003: This may potentially fix a chromium issue and shouldn't hurt, so if anyone agrees that this fix sho… (Closed)

Created:
7 years, 7 months ago by sugoi1
Modified:
7 years, 7 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This may potentially fix a chromium issue and shouldn't hurt, so if anyone agrees that this fix should be harmless, we can try merging it in to see if it's enough to fix "Invalid pointer write in GrRenderTarget::onRelease". R=bsalomon@google.com, robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=8982

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/gpu/gl/GrGpuGL.cpp View 3 chunks +7 lines, -2 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
sugoi1
If everyone agrees that this is harmless, I'll merge it in right away to see ...
7 years, 7 months ago (2013-05-02 21:14:32 UTC) #1
robertphillips
lgtm
7 years, 7 months ago (2013-05-02 21:24:57 UTC) #2
bsalomon
On 2013/05/02 21:24:57, robertphillips wrote: > lgtm lgtm
7 years, 7 months ago (2013-05-03 13:10:41 UTC) #3
sugoi1
7 years, 7 months ago (2013-05-03 13:52:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r8982 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698