Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1460653003: StaticImageBitmap::create should return PassRefPtr<StaticImageBitmap> (Closed)

Created:
5 years, 1 month ago by xidachen
Modified:
5 years, 1 month ago
Reviewers:
jbroman
CC:
jbroman, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

StaticImageBitmap::create should return PassRefPtr<StaticImageBitmap> instead of PassRefPtr<Image> Also, move the implementation of "imageForCurrentFrame()" to .cpp file. Committed: https://crrev.com/aa6e30c4d90f8edd660a015c8247477c0d10bf90 Cr-Commit-Position: refs/heads/master@{#360493}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/StaticBitmapImage.cpp View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
xidachen
Please review this CL, thank you.
5 years, 1 month ago (2015-11-18 21:12:33 UTC) #3
jbroman
lgtm
5 years, 1 month ago (2015-11-18 21:15:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460653003/1
5 years, 1 month ago (2015-11-18 21:16:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/142665)
5 years, 1 month ago (2015-11-18 23:08:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460653003/1
5 years, 1 month ago (2015-11-18 23:17:00 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 02:27:48 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 02:29:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa6e30c4d90f8edd660a015c8247477c0d10bf90
Cr-Commit-Position: refs/heads/master@{#360493}

Powered by Google App Engine
This is Rietveld 408576698