content/child/service_worker/service_worker_provider_context.cc - Issue 1460653002: ServiceWorker: Fix messed registration attributes on ServiceWorkerGlobalScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/service_worker_provider_context.cc

Issue 1460653002: ServiceWorker: Fix messed registration attributes on ServiceWorkerGlobalScope (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/service_worker_provider_context.cc

diff --git a/content/child/service_worker/service_worker_provider_context.cc b/content/child/service_worker/service_worker_provider_context.cc

index 9ef323ebcea2b7253b99fe2bccc20b33ce05df93..bc146210105dd5219101b336e79358e1e4f86d0c 100644

--- a/content/child/service_worker/service_worker_provider_context.cc

+++ b/content/child/service_worker/service_worker_provider_context.cc

@@ -92,7 +92,7 @@ class ServiceWorkerProviderContext::ControllerDelegate

scoped_ptr<ServiceWorkerHandleReference> active) override {

DCHECK(!registration_);

registration_ = registration.Pass();

- installing_ = active.Pass();

+ installing_ = installing.Pass();

waiting_ = waiting.Pass();

active_ = active.Pass();

}