Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 1460643002: Add chrome://tcmalloc/ to list of WebUI URLs (Closed)

Created:
5 years, 1 month ago by Dan Beam
Modified:
5 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chrome://tcmalloc/ to list of WebUI URLs R=isherman@chromium.org BUG=none Committed: https://crrev.com/cf16f0063008a6fc434a386860293d52c5a8b4ca Cr-Commit-Position: refs/heads/master@{#360479}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
Dan Beam
5 years, 1 month ago (2015-11-18 07:34:41 UTC) #3
Dan Beam
https://codereview.chromium.org/1460643002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1460643002/diff/1/tools/metrics/histograms/histograms.xml#newcode76307 tools/metrics/histograms/histograms.xml:76307: + <int value="581234974" label="chrome://tcmalloc/"/> this number brought to you ...
5 years, 1 month ago (2015-11-18 18:30:55 UTC) #4
Ilya Sherman
LGTM
5 years, 1 month ago (2015-11-18 23:39:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460643002/1
5 years, 1 month ago (2015-11-18 23:42:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 02:00:30 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 02:01:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf16f0063008a6fc434a386860293d52c5a8b4ca
Cr-Commit-Position: refs/heads/master@{#360479}

Powered by Google App Engine
This is Rietveld 408576698