Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1460633003: Roll buildtools 277db9302c..818123dac3 (Closed)

Created:
5 years, 1 month ago by tfarina
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools 277db9302c..818123dac3 In order to roll GN 8b4796b589..e8853384ca (r359874:r360325) and pick up the following changes: 354261e7dd49 Sort "deps" and "public_deps" when running the "gn format" command. 5b67bfea1fea fix gn bootstrap once again 45e4d2956883 tools/gn: mark first TestTarget parameter as const TBR=dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel Committed: https://crrev.com/bb7899ae390fe646bb6396a4b736e5ba4fbab747 Cr-Commit-Position: refs/heads/master@{#360504}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
tfarina
5 years, 1 month ago (2015-11-18 18:25:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460633003/1
5 years, 1 month ago (2015-11-18 18:28:19 UTC) #3
Dirk Pranke
aborting the CQ for the moment ... There are no actual GN changes listed in ...
5 years, 1 month ago (2015-11-18 18:30:08 UTC) #5
tfarina
I think it is a bug, there was a 'fatal: ambiguos argument' at the beginning. ...
5 years, 1 month ago (2015-11-18 18:34:32 UTC) #6
Dirk Pranke
updated/fixed the CL description and re-CQ'ing.
5 years, 1 month ago (2015-11-19 02:27:46 UTC) #11
Dirk Pranke
odd, we should have you try to do another roll and see if you get ...
5 years, 1 month ago (2015-11-19 02:28:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460633003/1
5 years, 1 month ago (2015-11-19 02:28:58 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 02:58:05 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 02:59:45 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb7899ae390fe646bb6396a4b736e5ba4fbab747
Cr-Commit-Position: refs/heads/master@{#360504}

Powered by Google App Engine
This is Rietveld 408576698