Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1460613003: Remove some FIXMEs from Push code (Closed)

Created:
5 years, 1 month ago by Peter Beverloo
Modified:
5 years, 1 month ago
CC:
chromium-reviews, blink-reviews, Peter Beverloo, johnme+watch_chromium.org, mvanouwerkerk+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some FIXMEs from Push code R=mvanouwerkerk BUG=440431 Committed: https://crrev.com/ed2e3fb8a158183b2746fdaf9ad964cc1e5b9240 Cr-Commit-Position: refs/heads/master@{#360379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/push_messaging/PushManager.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Michael van Ouwerkerk
lgtm
5 years, 1 month ago (2015-11-18 16:26:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460613003/1
5 years, 1 month ago (2015-11-18 16:29:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/142499)
5 years, 1 month ago (2015-11-18 17:59:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460613003/1
5 years, 1 month ago (2015-11-18 18:02:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 18:56:33 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 18:57:48 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ed2e3fb8a158183b2746fdaf9ad964cc1e5b9240
Cr-Commit-Position: refs/heads/master@{#360379}

Powered by Google App Engine
This is Rietveld 408576698