Add MemoryPurgeController.ReclaimedPartitionAllocInactiveTab

Add MemoryPurgeController.ReclaimedPartitionAllocInactiveTab

This UMA reports how much memory did MemoryPurgeController reclaim.

BUG=519146
Committed: https://crrev.com/49692720596605040ae77fdf2fa28e18d1114eeb
Cr-Commit-Position: refs/heads/master@{#361284}

[bashi, 2015-11-18 03:18:18]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org

[bashi, 2015-11-18 03:18:18]

WDYT about adding this UMA?

[haraken, 2015-11-18 03:45:40]

LGTM

https://codereview.chromium.org/1460603002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1460603002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:19480: +<histogram
name="Memory.RendererInactiveTabReclaimed" units="KB">

Shall we rename this to MemoryPurgeController.ReclaimedPartitionAllocMemory?

[bashi, 2015-11-18 04:50:19]

https://codereview.chromium.org/1460603002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1460603002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:19480: +<histogram
name="Memory.RendererInactiveTabReclaimed" units="KB">
On 2015/11/18 03:45:39, haraken wrote:
> 
> Shall we rename this to MemoryPurgeController.ReclaimedPartitionAllocMemory?

This UMA is only reported when a page becomes inactive. Are you suggesting that
I should move this UMA to MemoryPurgeController::purgeMemory() ?

[haraken, 2015-11-18 04:52:42]

On 2015/11/18 04:50:19, bashi1 wrote:
>
https://codereview.chromium.org/1460603002/diff/1/tools/metrics/histograms/hi...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/1460603002/diff/1/tools/metrics/histograms/hi...
> tools/metrics/histograms/histograms.xml:19480: +<histogram
> name="Memory.RendererInactiveTabReclaimed" units="KB">
> On 2015/11/18 03:45:39, haraken wrote:
> > 
> > Shall we rename this to MemoryPurgeController.ReclaimedPartitionAllocMemory?
> 
> This UMA is only reported when a page becomes inactive. Are you suggesting
that
> I should move this UMA to MemoryPurgeController::purgeMemory() ?

ah, then MemoryPurgeController.ReclaimedPartitionAllocMemoryInInactiveTab?

My point is just that we want to prefix the UMA with "MemoryPurgeController.".
"Memory." is too generic to group related UMAs (e.g., we use "BlinkGC.", "V8.",
"PartitionAlloc." etc).

[bashi, 2015-11-18 05:05:00]

Description was changed from

==========
Add Memory.RendererInactiveTabReclaimedSize

This UMA reports how much memory did MemoryPurgeController reclaim.

BUG=519146
==========

to

==========
Add MemoryPurgeController.ReclaimedPartitionAllocInactiveTab

This UMA reports how much memory did MemoryPurgeController reclaim.

BUG=519146
==========

[bashi, 2015-11-18 05:05:00]

bashi@chromium.org changed reviewers:
+ rkaplow@chromium.org

[bashi, 2015-11-18 05:05:41]

On 2015/11/18 04:52:42, haraken wrote:
> On 2015/11/18 04:50:19, bashi1 wrote:
> >
>
https://codereview.chromium.org/1460603002/diff/1/tools/metrics/histograms/hi...
> > File tools/metrics/histograms/histograms.xml (right):
> > 
> >
>
https://codereview.chromium.org/1460603002/diff/1/tools/metrics/histograms/hi...
> > tools/metrics/histograms/histograms.xml:19480: +<histogram
> > name="Memory.RendererInactiveTabReclaimed" units="KB">
> > On 2015/11/18 03:45:39, haraken wrote:
> > > 
> > > Shall we rename this to
MemoryPurgeController.ReclaimedPartitionAllocMemory?
> > 
> > This UMA is only reported when a page becomes inactive. Are you suggesting
> that
> > I should move this UMA to MemoryPurgeController::purgeMemory() ?
> 
> ah, then MemoryPurgeController.ReclaimedPartitionAllocMemoryInInactiveTab?
> 
> My point is just that we want to prefix the UMA with "MemoryPurgeController.".
> "Memory." is too generic to group related UMAs (e.g., we use "BlinkGC.",
"V8.",
> "PartitionAlloc." etc).

Done.

rkaplow@, PTAL at histogram.xml?

[rkaplow, 2015-11-18 16:08:00]

https://codereview.chromium.org/1460603002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/MemoryPurgeController.cpp (right):

https://codereview.chromium.org/1460603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/MemoryPurgeController.cpp:58:
Platform::current()->histogramEnumeration("MemoryPurgeController.ReclaimedPartitionAllocInactiveTab",
reclaimedInKB, maxSizeInKB);
this isn't the correct histogram method - this should be a counts histogram.

[bashi, 2015-11-19 23:16:36]

https://codereview.chromium.org/1460603002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/MemoryPurgeController.cpp (right):

https://codereview.chromium.org/1460603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/MemoryPurgeController.cpp:58:
Platform::current()->histogramEnumeration("MemoryPurgeController.ReclaimedPartitionAllocInactiveTab",
reclaimedInKB, maxSizeInKB);
On 2015/11/18 16:08:00, rkaplow wrote:
> this isn't the correct histogram method - this should be a counts histogram.

Done.

[rkaplow, 2015-11-20 23:13:46]

lgtm

https://codereview.chromium.org/1460603002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/MemoryPurgeController.cpp (right):

https://codereview.chromium.org/1460603002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/MemoryPurgeController.cpp:58:
Platform::current()->histogramCustomCounts("MemoryPurgeController.ReclaimedPartitionAllocInactiveTab",
reclaimedInKB, 0, maxSizeInKB, 50);
usually should be 1 as the min

[bashi, 2015-11-24 00:31:11]

https://codereview.chromium.org/1460603002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/MemoryPurgeController.cpp (right):

https://codereview.chromium.org/1460603002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/MemoryPurgeController.cpp:58:
Platform::current()->histogramCustomCounts("MemoryPurgeController.ReclaimedPartitionAllocInactiveTab",
reclaimedInKB, 0, maxSizeInKB, 50);
On 2015/11/20 23:13:46, rkaplow wrote:
> usually should be 1 as the min

Done.

[bashi, 2015-11-24 00:31:16]

The CQ bit was checked by bashi@chromium.org

[bashi, 2015-11-24 00:31:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/1460603002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-11-24 00:38:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1460603002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1460603002/60001

[commit-bot: I haz the power, 2015-11-24 03:38:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 03:38:38]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bashi, 2015-11-24 03:47:42]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2015-11-24 03:50:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1460603002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1460603002/60001

[commit-bot: I haz the power, 2015-11-24 05:29:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 05:29:35]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bashi, 2015-11-24 07:40:02]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2015-11-24 07:41:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1460603002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1460603002/60001

[commit-bot: I haz the power, 2015-11-24 08:15:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-24 08:16:11]

Patchset 4 (id:??) landed as
https://crrev.com/49692720596605040ae77fdf2fa28e18d1114eeb
Cr-Commit-Position: refs/heads/master@{#361284}