Make protocol::ConnectionToClient an abstract interface.

remoting/host/chromoting_host_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/memory/scoped_ptr.h"
 #include "remoting/base/auto_thread_task_runner.h"
 #include "remoting/host/audio_capturer.h"
 #include "remoting/host/chromoting_host.h"
@@ skipping 100 matching lines @@
     session_unowned_jid2_ = "user4@doman/rest-of-jid";
 
     EXPECT_CALL(*session1_, jid())
         .WillRepeatedly(ReturnRef(session_jid1_));
     EXPECT_CALL(*session2_, jid())
         .WillRepeatedly(ReturnRef(session_jid2_));
     EXPECT_CALL(*session_unowned1_, jid())
         .WillRepeatedly(ReturnRef(session_unowned_jid1_));
     EXPECT_CALL(*session_unowned2_, jid())
         .WillRepeatedly(ReturnRef(session_unowned_jid2_));
-    EXPECT_CALL(*session1_, SetEventHandler(_))
-        .Times(AnyNumber());
-    EXPECT_CALL(*session2_, SetEventHandler(_))
-        .Times(AnyNumber());
     EXPECT_CALL(*session_unowned1_, SetEventHandler(_))
         .Times(AnyNumber())
         .WillRepeatedly(SaveArg<0>(&session_unowned1_event_handler_));
     EXPECT_CALL(*session_unowned2_, SetEventHandler(_))
         .Times(AnyNumber())
         .WillRepeatedly(SaveArg<0>(&session_unowned2_event_handler_));
     EXPECT_CALL(*session1_, config())
         .WillRepeatedly(ReturnRef(*session_config1_));
     EXPECT_CALL(*session2_, config())
         .WillRepeatedly(ReturnRef(*session_config2_));
 
-    owned_connection1_.reset(new MockConnectionToClient(session1_,
-                                                        &host_stub1_));
+    owned_connection1_.reset(
+        new MockConnectionToClient(make_scoped_ptr(session1_), &host_stub1_));
     connection1_ = owned_connection1_.get();
-    owned_connection2_.reset(new MockConnectionToClient(session2_,
-                                                        &host_stub2_));
+    owned_connection2_.reset(
+        new MockConnectionToClient(make_scoped_ptr(session2_), &host_stub2_));
     connection2_ = owned_connection2_.get();
 
     ON_CALL(video_stub1_, ProcessVideoPacketPtr(_, _))
         .WillByDefault(DeleteArg<0>());
     ON_CALL(video_stub2_, ProcessVideoPacketPtr(_, _))
         .WillByDefault(DeleteArg<0>());
     ON_CALL(*connection1_, video_stub())
         .WillByDefault(Return(&video_stub1_));
     ON_CALL(*connection1_, client_stub())
         .WillByDefault(Return(&client_stub1_));
-    ON_CALL(*connection1_, session())
-        .WillByDefault(Return(session1_));
     ON_CALL(*connection2_, video_stub())
         .WillByDefault(Return(&video_stub2_));
     ON_CALL(*connection2_, client_stub())
         .WillByDefault(Return(&client_stub2_));
-    ON_CALL(*connection2_, session())
-        .WillByDefault(Return(session2_));
     EXPECT_CALL(*connection1_, video_stub())
         .Times(AnyNumber());
     EXPECT_CALL(*connection1_, client_stub())
         .Times(AnyNumber());
-    EXPECT_CALL(*connection1_, session())
-        .Times(AnyNumber());
     EXPECT_CALL(*connection2_, video_stub())
         .Times(AnyNumber());
     EXPECT_CALL(*connection2_, client_stub())
         .Times(AnyNumber());
-    EXPECT_CALL(*connection2_, session())
-        .Times(AnyNumber());
   }
 
   // Helper method to pretend a client is connected to ChromotingHost.
   void SimulateClientConnection(int connection_index, bool authenticate,
                                 bool reject) {
     scoped_ptr<protocol::ConnectionToClient> connection =
         ((connection_index == 0) ? owned_connection1_ : owned_connection2_)
             .Pass();
     protocol::ConnectionToClient* connection_ptr = connection.get();
     scoped_ptr<ClientSession> client(new ClientSession(
@@ skipping 489 matching lines @@
   ExpectClientDisconnected(0, true, video_packet_sent,
       InvokeWithoutArgs(this, &ChromotingHostTest::ShutdownHost));
   EXPECT_CALL(host_status_observer_, OnShutdown());
 
   host_->Start(xmpp_login_);
   SimulateClientConnection(0, true, false);
   message_loop_.Run();
 }
 
 }  // namespace remoting