Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1460593005: Make protocol::ConnectionToClient an abstract interface. (Closed)

Created:
5 years, 1 month ago by Sergey Ulanov
Modified:
5 years, 1 month ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make protocol::ConnectionToClient an abstract interface. Moved existing code to IceConnectionToClient. In future a new WebrtcConnectionToClient will handle webrtc-based connection. BUG=547158 Committed: https://crrev.com/b031cd25bae275aa1668b5850ed1d8e9668f6e41 Cr-Commit-Position: refs/heads/master@{#360673}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -465 lines) Patch
M remoting/host/chromoting_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 3 chunks +4 lines, -16 lines 0 comments Download
M remoting/host/client_session.cc View 1 chunk +2 lines, -0 lines 2 comments Download
M remoting/host/client_session_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M remoting/protocol/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/connection_to_client.h View 2 chunks +22 lines, -63 lines 0 comments Download
D remoting/protocol/connection_to_client.cc View 1 chunk +0 lines, -195 lines 0 comments Download
D remoting/protocol/connection_to_client_unittest.cc View 1 chunk +0 lines, -114 lines 0 comments Download
A remoting/protocol/ice_connection_to_client.h View 1 chunk +87 lines, -0 lines 0 comments Download
A + remoting/protocol/ice_connection_to_client.cc View 6 chunks +44 lines, -41 lines 0 comments Download
A + remoting/protocol/ice_connection_to_client_unittest.cc View 5 chunks +10 lines, -12 lines 0 comments Download
M remoting/protocol/protocol_mock_objects.h View 2 chunks +17 lines, -6 lines 0 comments Download
M remoting/protocol/protocol_mock_objects.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M remoting/remoting_srcs.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/remoting_test.gypi View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Sergey Ulanov
5 years, 1 month ago (2015-11-18 20:56:09 UTC) #4
kelvinp
lgtm https://codereview.chromium.org/1460593005/diff/1/remoting/host/client_session.cc File remoting/host/client_session.cc (right): https://codereview.chromium.org/1460593005/diff/1/remoting/host/client_session.cc#newcode36 remoting/host/client_session.cc:36: #include "remoting/protocol/session_config.h" Why is this needed? Is that ...
5 years, 1 month ago (2015-11-19 19:49:16 UTC) #5
Sergey Ulanov
https://codereview.chromium.org/1460593005/diff/1/remoting/host/client_session.cc File remoting/host/client_session.cc (right): https://codereview.chromium.org/1460593005/diff/1/remoting/host/client_session.cc#newcode36 remoting/host/client_session.cc:36: #include "remoting/protocol/session_config.h" On 2015/11/19 19:49:16, kelvinp wrote: > Why ...
5 years, 1 month ago (2015-11-19 19:59:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460593005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460593005/1
5 years, 1 month ago (2015-11-19 20:31:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 22:17:21 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 22:18:42 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b031cd25bae275aa1668b5850ed1d8e9668f6e41
Cr-Commit-Position: refs/heads/master@{#360673}

Powered by Google App Engine
This is Rietveld 408576698