Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1460593004: Revert of p1 mus+ash chrome renders ui and content (Closed)

Created:
5 years, 1 month ago by msramek
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of p1 mus+ash chrome renders ui and content (patchset #9 id:160001 of https://codereview.chromium.org/1438903002/ ) Reason for revert: Broken compilation: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/5923 Original issue's description: > p1 mus+ash chrome renders ui and content > > This patch forces mus+ash Chrome to software composite the ui and content > region into a single bitmap that is uploaded to the mus window server. The > approach here is similar to how Chrome paints to X11 when hardware acceleration > is not available. > > BUG=554699 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/e482a6010424204e7c8e313c5922acc38506be5c > Cr-Commit-Position: refs/heads/master@{#360289} TBR=sky@chromium.org,jam@chromium.org,fsamuel@chromium.org,ben@chromium.org,ccameron@chromium.org,rjkroege@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=554699, 557595 Committed: https://crrev.com/215dc6104e6970fc8fe99cc44a0f78de9618a591 Cr-Commit-Position: refs/heads/master@{#360314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -178 lines) Patch
M base/threading/thread_restrictions.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M components/bitmap_uploader/bitmap_uploader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/bitmap_uploader/bitmap_uploader.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -7 lines 0 comments Download
M content/browser/compositor/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 3 chunks +0 lines, -19 lines 0 comments Download
D content/browser/compositor/software_output_device_mus.h View 1 chunk +0 lines, -36 lines 0 comments Download
D content/browser/compositor/software_output_device_mus.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M ui/views/mus/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M ui/views/mus/platform_window_mus.cc View 2 chunks +1 line, -15 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.h View 4 chunks +0 lines, -10 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
msramek
Created Revert of p1 mus+ash chrome renders ui and content
5 years, 1 month ago (2015-11-18 09:47:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460593004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460593004/1
5 years, 1 month ago (2015-11-18 09:49:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 09:50:21 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 09:51:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/215dc6104e6970fc8fe99cc44a0f78de9618a591
Cr-Commit-Position: refs/heads/master@{#360314}

Powered by Google App Engine
This is Rietveld 408576698