Remove Undo Options from DeviceClassManager

Remove Undo Options from DeviceClassManager

Undo is a per-activity setting, not a per-device setting. Therefore it
is not appropriate to let DeviceClassManager singleton to handle whether
undo is allowed.

Also it turns out that as long as TabModelImpl is only used in
ChromeTabbedActivity, undo is always going to to be enabled, so there is
no point that ENABLE_HIGH_END_UI_UNDO should exist.

BUG=555500
Committed: https://crrev.com/78741ac39ab95671d11c7975f78847f784687550
Cr-Commit-Position: refs/heads/master@{#360495}

[Ian Wen, 2015-11-18 01:20:34]

ianwen@chromium.org changed reviewers:
+ newt@chromium.org

[Ian Wen, 2015-11-18 01:20:35]

PTAL

[Ian Wen, 2015-11-18 18:51:27]

ianwen@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ian Wen, 2015-11-18 18:51:28]

https://chromiumcodereview.appspot.com/1460573002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java
(right):

https://chromiumcodereview.appspot.com/1460573002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java:67:
return DeviceClassManager.isAccessibilityModeEnabled(mContext)
I think disableUndo() function can be just removed.

Only classes used by ChromeTabbedActivity care about enableUndo(), and after
enableUndo() is removed undo is always enabled in ChromeTabbedActivity.

Previously accessibility is checked here because we wanted to force undo in talk
back mode even if it is disabled. Now this is never going to happen.

[Ted C, 2015-11-19 00:21:17]

lgtm

https://codereview.chromium.org/1460573002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java
(right):

https://codereview.chromium.org/1460573002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java:67:
return DeviceClassManager.isAccessibilityModeEnabled(mContext)
On 2015/11/18 18:51:27, Ian Wen wrote:
> I think disableUndo() function can be just removed.
> 
> Only classes used by ChromeTabbedActivity care about enableUndo(), and after
> enableUndo() is removed undo is always enabled in ChromeTabbedActivity.
> 
> Previously accessibility is checked here because we wanted to force undo in
talk
> back mode even if it is disabled. Now this is never going to happen.

I think we need to keep this here because if you are in the accessibility tab
switcher then undo is shown inline instead of as a toast.

https://codereview.chromium.org/1460573002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java
(right):

https://codereview.chromium.org/1460573002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java:14:
import org.chromium.chrome.browser.snackbar.undo.UndoBarPopupController;
Hmm...Why the new imports?

[Ian Wen, 2015-11-19 01:27:53]

All done.

https://codereview.chromium.org/1460573002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java
(right):

https://codereview.chromium.org/1460573002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java:67:
return DeviceClassManager.isAccessibilityModeEnabled(mContext)
On 2015/11/19 00:21:16, Ted C wrote:
> On 2015/11/18 18:51:27, Ian Wen wrote:
> > I think disableUndo() function can be just removed.
> > 
> > Only classes used by ChromeTabbedActivity care about enableUndo(), and after
> > enableUndo() is removed undo is always enabled in ChromeTabbedActivity.
> > 
> > Previously accessibility is checked here because we wanted to force undo in
> talk
> > back mode even if it is disabled. Now this is never going to happen.
> 
> I think we need to keep this here because if you are in the accessibility tab
> switcher then undo is shown inline instead of as a toast.

Oh yeah you are right. This function is "disable", not "enable". I was confused
when I re-read this CL.

https://codereview.chromium.org/1460573002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java
(right):

https://codereview.chromium.org/1460573002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java:14:
import org.chromium.chrome.browser.snackbar.undo.UndoBarPopupController;
On 2015/11/19 00:21:16, Ted C wrote:
> Hmm...Why the new imports?

I think eclipse auto imported those for the javadocs. Removed these imports.

[Ian Wen, 2015-11-19 01:27:58]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-11-19 01:27:58]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/1460573002/#ps20001
(title: "Remove phantom imports")

[commit-bot: I haz the power, 2015-11-19 01:29:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1460573002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1460573002/20001

[commit-bot: I haz the power, 2015-11-19 02:29:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-19 02:30:30]

Patchset 2 (id:??) landed as
https://crrev.com/78741ac39ab95671d11c7975f78847f784687550
Cr-Commit-Position: refs/heads/master@{#360495}