Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1460563002: [es6] Partially implement Reflect.ownKeys. (Closed)

Created:
5 years, 1 month ago by neis
Modified:
5 years, 1 month ago
Reviewers:
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Partially implement Reflect.ownKeys. Proxies are not properly supported yet. This is a reland of 1405243006. TBR=rossberg@chromium.org Committed: https://crrev.com/b27081338856e700a68975088932e9dd03b44cc7 Cr-Commit-Position: refs/heads/master@{#32065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -60 lines) Patch
M src/bootstrapper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M src/objects.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/objects.cc View 5 chunks +9 lines, -5 lines 0 comments Download
M test/mjsunit/harmony/reflect.js View 1 chunk +33 lines, -0 lines 0 comments Download
A + test/mjsunit/harmony/reflect-own-keys.js View 2 chunks +41 lines, -54 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460563002/1
5 years, 1 month ago (2015-11-18 00:23:55 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-18 00:48:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460563002/1
5 years, 1 month ago (2015-11-18 00:51:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 00:52:35 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 00:53:00 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b27081338856e700a68975088932e9dd03b44cc7
Cr-Commit-Position: refs/heads/master@{#32065}

Powered by Google App Engine
This is Rietveld 408576698