Issue 146053007: Update safe_browsing code to use WebElementCollection instead of WebNodeCollection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146053007: Update safe_browsing code to use WebElementCollection instead of WebNodeCollection (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
Nico, jochen (gone - plz use gerrit)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update safe_browsing code to use WebElementCollection instead of WebNodeCollection Update safe_browsing code to use WebElementCollection instead of WebNodeCollection. After Blink r166411 and r166500, WebNodeCollection is renamed to WebElementCollection and its API returns WebElements instead of WebNodes. The new code is clearer and avoids unnecessary isElementNode() checks. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249720

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -30 lines)			Patch
	M	chrome/renderer/safe_browsing/malware_dom_details.cc	View		2 chunks	+4 lines, -8 lines	0 comments	Download
	M	chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc	View		4 chunks	+19 lines, -22 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/146053007/50001

6 years, 10 months ago (2014-02-07 14:34:41 UTC) #4

Message was sent while issue was closed.

Change committed as 249720

Expand Messages | Collapse Messages