Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1460523004: Avoid unnecessary wtf/text/WTFString.h includes in platform/heap/ (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, kenneth.christiansen, oilpan-reviews, Mads Ager (chromium), sof, eae+blinkwatch, tommyw+watchlist_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, kouhei+heap_chromium.org, rwlbuis, jbroman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid unnecessary wtf/text/WTFString.h includes in platform/heap/ Oilpan header files are included across most of Blink, so tidy up various downstream code that implicitly assumed WTFString.h's offerings to be in scope. R=haraken BUG= Committed: https://crrev.com/b17e305bdace0162607619fe17775c1e91f7f6e7 Cr-Commit-Position: refs/heads/master@{#360525}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
sof
please take a look.
5 years, 1 month ago (2015-11-18 16:55:01 UTC) #2
haraken
LGTM
5 years, 1 month ago (2015-11-18 23:37:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460523004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460523004/1
5 years, 1 month ago (2015-11-19 04:54:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 04:59:39 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 05:00:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b17e305bdace0162607619fe17775c1e91f7f6e7
Cr-Commit-Position: refs/heads/master@{#360525}

Powered by Google App Engine
This is Rietveld 408576698