GIF decoding to Index8, unit tests and misusing unit test as benchmark

third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

Index: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp
diff --git a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp
index 7b878dd79c3b7f394ae43983092c9e6a741a636f..4b99b0cc1e38cb0c462c6677eaedfefe4482b885 100644
--- a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp
+++ b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp
@@ -53,7 +53,87 @@ PassOwnPtr<ImageDecoder> createDecoder()
     return adoptPtr(new GIFImageDecoder(ImageDecoder::AlphaNotPremultiplied, ImageDecoder::GammaAndColorProfileApplied, ImageDecoder::noDecodedImageByteLimit));
 }
 
-void testRandomFrameDecode(const char* dir, const char* gifFile)
+static bool areFramesColorsEqual(ImageFrame* b1, ImageFrame* b2)

[scroggo_chromium, 2015/12/03 21:47:22]

can these be const references?

[aleksandar.stojiljkovic, 2015/12/22 15:19:55]

Done.

+{
+    // The same premultiply alpha should be set.
+    if (b1->premultiplyAlpha() != b2->premultiplyAlpha())
+        return false;
+    if (b1->getSkBitmap().width() != b2->getSkBitmap().width()
+        || b1->getSkBitmap().height() != b2->getSkBitmap().height())
+        return false;
+
+    int width = b1->getSkBitmap().width();

[scroggo_chromium, 2015/12/03 21:47:22]

Why not set these variables before the last if statement, so you can use them
instead of calling the methods again?

[aleksandar.stojiljkovic, 2015/12/22 15:19:55]

Done.

+    int height = b1->getSkBitmap().height();
+    for (int j = 0; j < height; ++j) {
+        for (int i = 0; i < width; ++i) {
+            uint32_t c1 = b1->getSkBitmap().getColor(i, j);
+            uint32_t c2 = b2->getSkBitmap().getColor(i, j);
+            if (c1 != c2) {
+                return false;
+            }
+        }
+    }
+    return true;
+}
+
+void testRandomFrameDecode(const char* dir, const char* gifFile, ImageFrame::ColorType targetType = ImageFrame::N32)
+{
+    SCOPED_TRACE(gifFile);
+
+    RefPtr<SharedBuffer> fullData = readFile(dir, gifFile);
+    ASSERT_TRUE(fullData.get());
+    Vector<unsigned> baselineHashes;
+    createDecodingBaseline(&createDecoder, fullData.get(), &baselineHashes, targetType);
+    size_t frameCount = baselineHashes.size();
+
+    // Random decoding should get the same results as sequential decoding.
+    OwnPtr<ImageDecoder> decoder = createDecoder();
+    decoder->setData(fullData.get(), true);
+    const size_t skippingStep = 5;
+    for (size_t i = 0; i < skippingStep; ++i) {
+        for (size_t j = i; j < frameCount; j += skippingStep) {
+            SCOPED_TRACE(testing::Message() << "Random i:" << i << " j:" << j);
+            ImageFrame* frame = decoder->frameBufferAtIndex(j, targetType);
+            EXPECT_EQ(baselineHashes[j], hashBitmap(frame->getSkBitmap()));
+        }
+    }
+
+    // Decoding in reverse order.
+    decoder = createDecoder();
+    decoder->setData(fullData.get(), true);
+    for (size_t i = frameCount; i; --i) {
+        SCOPED_TRACE(testing::Message() << "Reverse i:" << i);
+        ImageFrame* frame = decoder->frameBufferAtIndex(i - 1, targetType);
+        EXPECT_EQ(baselineHashes[i - 1], hashBitmap(frame->getSkBitmap()));
+    }
+}
+
+void testRandomDecodeAfterClearFrameBufferCache(const char* dir, const char* gifFile, ImageFrame::ColorType targetType = ImageFrame::N32)
+{
+    SCOPED_TRACE(gifFile);
+
+    RefPtr<SharedBuffer> data = readFile(dir, gifFile);
+    ASSERT_TRUE(data.get());
+    Vector<unsigned> baselineHashes;
+    createDecodingBaseline(&createDecoder, data.get(), &baselineHashes, targetType);
+    size_t frameCount = baselineHashes.size();
+
+    OwnPtr<ImageDecoder> decoder = createDecoder();
+    decoder->setData(data.get(), true);
+    for (size_t clearExceptFrame = 0; clearExceptFrame < frameCount; ++clearExceptFrame) {
+        decoder->clearCacheExceptFrame(clearExceptFrame);
+        const size_t skippingStep = 5;
+        for (size_t i = 0; i < skippingStep; ++i) {
+            for (size_t j = 0; j < frameCount; j += skippingStep) {
+                SCOPED_TRACE(testing::Message() << "Random i:" << i << " j:" << j);
+                ImageFrame* frame = decoder->frameBufferAtIndex(j, targetType);
+                EXPECT_EQ(baselineHashes[j], hashBitmap(frame->getSkBitmap()));
+            }
+        }
+    }
+}
+
+void testRandomFrameDecodeCompare(const char* dir, const char* gifFile)
 {
     SCOPED_TRACE(gifFile);
 
@@ -65,27 +145,37 @@ void testRandomFrameDecode(const char* dir, const char* gifFile)
 
     // Random decoding should get the same results as sequential decoding.
     OwnPtr<ImageDecoder> decoder = createDecoder();
+    // Test Index8 and RGBA through the same scenario.
+    OwnPtr<ImageDecoder> decoderI8 = createDecoder();
+
     decoder->setData(fullData.get(), true);
+    decoderI8->setData(fullData.get(), true);
     const size_t skippingStep = 5;
     for (size_t i = 0; i < skippingStep; ++i) {
         for (size_t j = i; j < frameCount; j += skippingStep) {
             SCOPED_TRACE(testing::Message() << "Random i:" << i << " j:" << j);
             ImageFrame* frame = decoder->frameBufferAtIndex(j);
             EXPECT_EQ(baselineHashes[j], hashBitmap(frame->getSkBitmap()));
+            ImageFrame* frameI8 = decoderI8->frameBufferAtIndex(j, ImageFrame::Index8);
+            ASSERT_TRUE(areFramesColorsEqual(frame, frameI8));
         }
     }
 
     // Decoding in reverse order.
     decoder = createDecoder();
+    decoderI8 = createDecoder();
     decoder->setData(fullData.get(), true);
+    decoderI8->setData(fullData.get(), true);
     for (size_t i = frameCount; i; --i) {
         SCOPED_TRACE(testing::Message() << "Reverse i:" << i);
         ImageFrame* frame = decoder->frameBufferAtIndex(i - 1);
         EXPECT_EQ(baselineHashes[i - 1], hashBitmap(frame->getSkBitmap()));
+        ImageFrame* frameI8 = decoderI8->frameBufferAtIndex(i - 1, ImageFrame::Index8);
+        ASSERT_TRUE(areFramesColorsEqual(frame, frameI8));
     }
 }
 
-void testRandomDecodeAfterClearFrameBufferCache(const char* dir, const char* gifFile)
+void testRandomDecodeAfterClearFrameBufferCacheCompare(const char* dir, const char* gifFile)
 {
     SCOPED_TRACE(gifFile);
 
@@ -96,15 +186,21 @@ void testRandomDecodeAfterClearFrameBufferCache(const char* dir, const char* gif
     size_t frameCount = baselineHashes.size();
 
     OwnPtr<ImageDecoder> decoder = createDecoder();
+    // Test Index8 and RGBA through the same scenario.
+    OwnPtr<ImageDecoder> decoderI8 = createDecoder();
     decoder->setData(data.get(), true);
+    decoderI8->setData(data.get(), true);
     for (size_t clearExceptFrame = 0; clearExceptFrame < frameCount; ++clearExceptFrame) {
         decoder->clearCacheExceptFrame(clearExceptFrame);
+        decoderI8->clearCacheExceptFrame(clearExceptFrame);
         const size_t skippingStep = 5;
         for (size_t i = 0; i < skippingStep; ++i) {
-            for (size_t j = 0; j < frameCount; j += skippingStep) {
+            for (size_t j = 0; j < frameCount; j += (i + 2)) {
                 SCOPED_TRACE(testing::Message() << "Random i:" << i << " j:" << j);
                 ImageFrame* frame = decoder->frameBufferAtIndex(j);
                 EXPECT_EQ(baselineHashes[j], hashBitmap(frame->getSkBitmap()));
+                ImageFrame* frameI8 = decoderI8->frameBufferAtIndex(j, ImageFrame::Index8);
+                ASSERT_TRUE(areFramesColorsEqual(frame, frameI8));
             }
         }
     }
@@ -115,10 +211,12 @@ void testRandomDecodeAfterClearFrameBufferCache(const char* dir, const char* gif
 TEST(GIFImageDecoderTest, decodeTwoFrames)
 {
     OwnPtr<ImageDecoder> decoder = createDecoder();
+    OwnPtr<ImageDecoder> decoderI8 = createDecoder();
 
     RefPtr<SharedBuffer> data = readFile(layoutTestResourcesDir, "animated.gif");
     ASSERT_TRUE(data.get());
     decoder->setData(data.get(), true);
+    decoderI8->setData(data.get(), true);
     EXPECT_EQ(cAnimationLoopOnce, decoder->repetitionCount());
 
     ImageFrame* frame = decoder->frameBufferAtIndex(0);
@@ -127,6 +225,14 @@ TEST(GIFImageDecoderTest, decodeTwoFrames)
     EXPECT_EQ(16, frame->getSkBitmap().width());
     EXPECT_EQ(16, frame->getSkBitmap().height());
 
+    ImageFrame* frameI8 = decoderI8->frameBufferAtIndex(0, ImageFrame::Index8);
+    generationID0 = frameI8->getSkBitmap().getGenerationID();
+    EXPECT_EQ(ImageFrame::FrameComplete, frameI8->status());
+    EXPECT_EQ(16, frameI8->getSkBitmap().width());
+    EXPECT_EQ(16, frameI8->getSkBitmap().height());
+
+    ASSERT_TRUE(areFramesColorsEqual(frame, frameI8));
+
     frame = decoder->frameBufferAtIndex(1);
     uint32_t generationID1 = frame->getSkBitmap().getGenerationID();
     EXPECT_EQ(ImageFrame::FrameComplete, frame->status());
@@ -136,6 +242,11 @@ TEST(GIFImageDecoderTest, decodeTwoFrames)
 
     EXPECT_EQ(2u, decoder->frameCount());
     EXPECT_EQ(cAnimationLoopInfinite, decoder->repetitionCount());
+
+    frameI8 = decoderI8->frameBufferAtIndex(1, ImageFrame::Index8);
+    ASSERT_TRUE(areFramesColorsEqual(frame, frameI8));
+    EXPECT_EQ(2u, decoderI8->frameCount());
+    EXPECT_EQ(cAnimationLoopInfinite, decoderI8->repetitionCount());
 }
 
 TEST(GIFImageDecoderTest, parseAndDecode)
@@ -165,6 +276,7 @@ TEST(GIFImageDecoderTest, parseAndDecode)
 TEST(GIFImageDecoderTest, parseByteByByte)
 {
     OwnPtr<ImageDecoder> decoder = createDecoder();
+    OwnPtr<ImageDecoder> decoderI8 = createDecoder();
 
     RefPtr<SharedBuffer> data = readFile(layoutTestResourcesDir, "animated.gif");
     ASSERT_TRUE(data.get());
@@ -175,8 +287,11 @@ TEST(GIFImageDecoderTest, parseByteByByte)
     for (size_t length = 1; length <= data->size(); ++length) {
         RefPtr<SharedBuffer> tempData = SharedBuffer::create(data->data(), length);
         decoder->setData(tempData.get(), length == data->size());
+        decoderI8->setData(tempData.get(), length == data->size());
 
         EXPECT_LE(frameCount, decoder->frameCount());
+        EXPECT_LE(frameCount, decoderI8->frameCount());
+        EXPECT_EQ(decoder->frameCount(), decoderI8->frameCount());
         frameCount = decoder->frameCount();
     }
 
@@ -190,6 +305,7 @@ TEST(GIFImageDecoderTest, parseByteByByte)
 TEST(GIFImageDecoderTest, parseAndDecodeByteByByte)
 {
     OwnPtr<ImageDecoder> decoder = createDecoder();
+    OwnPtr<ImageDecoder> decoderI8 = createDecoder();
 
     RefPtr<SharedBuffer> data = readFile(layoutTestResourcesDir, "animated-gif-with-offsets.gif");
     ASSERT_TRUE(data.get());
@@ -201,13 +317,18 @@ TEST(GIFImageDecoderTest, parseAndDecodeByteByByte)
     for (size_t length = 1; length <= data->size(); ++length) {
         RefPtr<SharedBuffer> tempData = SharedBuffer::create(data->data(), length);
         decoder->setData(tempData.get(), length == data->size());
+        decoderI8->setData(tempData.get(), length == data->size());
 
         EXPECT_LE(frameCount, decoder->frameCount());
         frameCount = decoder->frameCount();
+        EXPECT_EQ(frameCount, decoderI8->frameCount());
 
         ImageFrame* frame = decoder->frameBufferAtIndex(frameCount - 1);
         if (frame && frame->status() == ImageFrame::FrameComplete && framesDecoded < frameCount)
             ++framesDecoded;
+
+        ImageFrame* frameI8 = decoderI8->frameBufferAtIndex(frameCount - 1, ImageFrame::Index8);
+        ASSERT_TRUE(!(frame || frameI8) || areFramesColorsEqual(frame, frameI8));
     }
 
     EXPECT_EQ(5u, decoder->frameCount());
@@ -227,6 +348,8 @@ TEST(GIFImageDecoderTest, brokenSecondFrame)
     EXPECT_EQ(1u, decoder->frameCount());
     ImageFrame* frame = decoder->frameBufferAtIndex(1);
     EXPECT_FALSE(frame);
+    frame = decoder->frameBufferAtIndex(1, ImageFrame::Index8);
+    EXPECT_FALSE(frame);
 }
 
 TEST(GIFImageDecoderTest, progressiveDecode)
@@ -361,28 +484,31 @@ TEST(GIFImageDecoderTest, badTerminator)
 
 TEST(GIFImageDecoderTest, updateRequiredPreviousFrameAfterFirstDecode)
 {
-    OwnPtr<ImageDecoder> decoder = createDecoder();
-
-    RefPtr<SharedBuffer> fullData = readFile(layoutTestResourcesDir, "animated-10color.gif");
-    ASSERT_TRUE(fullData.get());
-
-    // Give it data that is enough to parse but not decode in order to check the status
-    // of requiredPreviousFrameIndex before decoding.
-    size_t partialSize = 1;
-    do {
-        RefPtr<SharedBuffer> data = SharedBuffer::create(fullData->data(), partialSize);
-        decoder->setData(data.get(), false);
-        ++partialSize;
-    } while (!decoder->frameCount() || decoder->frameBufferAtIndex(0)->status() == ImageFrame::FrameEmpty);
-
-    EXPECT_EQ(kNotFound, decoder->frameBufferAtIndex(0)->requiredPreviousFrameIndex());
-    unsigned frameCount = decoder->frameCount();
-    for (size_t i = 1; i < frameCount; ++i)
-        EXPECT_EQ(i - 1, decoder->frameBufferAtIndex(i)->requiredPreviousFrameIndex());
-
-    decoder->setData(fullData.get(), true);
-    for (size_t i = 0; i < frameCount; ++i)
-        EXPECT_EQ(kNotFound, decoder->frameBufferAtIndex(i)->requiredPreviousFrameIndex());
+    const ImageFrame::ColorType targetTypes[] = { ImageFrame::N32, ImageFrame::Index8 };
+    for (ImageFrame::ColorType targetType : targetTypes) {
+        OwnPtr<ImageDecoder> decoder = createDecoder();
+
+        RefPtr<SharedBuffer> fullData = readFile(layoutTestResourcesDir, "animated-10color.gif");
+        ASSERT_TRUE(fullData.get());
+
+        // Give it data that is enough to parse but not decode in order to check the status
+        // of requiredPreviousFrameIndex before decoding.
+        size_t partialSize = 1;
+        do {
+            RefPtr<SharedBuffer> data = SharedBuffer::create(fullData->data(), partialSize);
+            decoder->setData(data.get(), false);
+            ++partialSize;
+        } while (!decoder->frameCount() || decoder->frameBufferAtIndex(0, targetType)->status() == ImageFrame::FrameEmpty);
+
+        EXPECT_EQ(kNotFound, decoder->frameBufferAtIndex(0, targetType)->requiredPreviousFrameIndex());
+        unsigned frameCount = decoder->frameCount();
+        for (size_t i = 1; i < frameCount; ++i)
+            EXPECT_EQ(i - 1, decoder->frameBufferAtIndex(i, targetType)->requiredPreviousFrameIndex());
+
+        decoder->setData(fullData.get(), true);
+        for (size_t i = 0; i < frameCount; ++i)
+            EXPECT_EQ(kNotFound, decoder->frameBufferAtIndex(i, targetType)->requiredPreviousFrameIndex());
+    }
 }
 
 TEST(GIFImageDecoderTest, randomFrameDecode)
@@ -394,6 +520,15 @@ TEST(GIFImageDecoderTest, randomFrameDecode)
     testRandomFrameDecode(layoutTestResourcesDir, "animated-10color.gif");
 }
 
+TEST(GIFImageDecoderTest, randomFrameDecodeCompare)
+{
+    // Single frame image.
+    testRandomFrameDecodeCompare(webTestsDataDir, "radient.gif");
+    // Multiple frame images.
+    testRandomFrameDecodeCompare(layoutTestResourcesDir, "animated-gif-with-offsets.gif");
+    testRandomFrameDecodeCompare(layoutTestResourcesDir, "animated-10color.gif");
+}
+
 TEST(GIFImageDecoderTest, randomDecodeAfterClearFrameBufferCache)
 {
     // Single frame image.
@@ -403,35 +538,47 @@ TEST(GIFImageDecoderTest, randomDecodeAfterClearFrameBufferCache)
     testRandomDecodeAfterClearFrameBufferCache(layoutTestResourcesDir, "animated-10color.gif");
 }
 
-TEST(GIFImageDecoderTest, resumePartialDecodeAfterClearFrameBufferCache)
+TEST(GIFImageDecoderTest, randomDecodeAfterClearFrameBufferCacheCompare)
 {
-    RefPtr<SharedBuffer> fullData = readFile(layoutTestResourcesDir, "animated-10color.gif");
-    ASSERT_TRUE(fullData.get());
-    Vector<unsigned> baselineHashes;
-    createDecodingBaseline(&createDecoder, fullData.get(), &baselineHashes);
-    size_t frameCount = baselineHashes.size();
-
-    OwnPtr<ImageDecoder> decoder = createDecoder();
-
-    // Let frame 0 be partially decoded.
-    size_t partialSize = 1;
-    do {
-        RefPtr<SharedBuffer> data = SharedBuffer::create(fullData->data(), partialSize);
-        decoder->setData(data.get(), false);
-        ++partialSize;
-    } while (!decoder->frameCount() || decoder->frameBufferAtIndex(0)->status() == ImageFrame::FrameEmpty);
+    // Single frame image.
+    testRandomDecodeAfterClearFrameBufferCacheCompare(webTestsDataDir, "radient.gif");
+    // Multiple frame images with offset. All frames depend to frame 0.
+    testRandomDecodeAfterClearFrameBufferCacheCompare(layoutTestResourcesDir, "animated-gif-with-offsets.gif");
+    testRandomDecodeAfterClearFrameBufferCacheCompare(layoutTestResourcesDir, "animated-10color.gif");
+}
 
-    // Skip to the last frame and clear.
-    decoder->setData(fullData.get(), true);
-    EXPECT_EQ(frameCount, decoder->frameCount());
-    ImageFrame* lastFrame = decoder->frameBufferAtIndex(frameCount - 1);
-    EXPECT_EQ(baselineHashes[frameCount - 1], hashBitmap(lastFrame->getSkBitmap()));
-    decoder->clearCacheExceptFrame(kNotFound);
-
-    // Resume decoding of the first frame.
-    ImageFrame* firstFrame = decoder->frameBufferAtIndex(0);
-    EXPECT_EQ(ImageFrame::FrameComplete, firstFrame->status());
-    EXPECT_EQ(baselineHashes[0], hashBitmap(firstFrame->getSkBitmap()));
+TEST(GIFImageDecoderTest, resumePartialDecodeAfterClearFrameBufferCache)
+{
+    const ImageFrame::ColorType targetTypes[] = { ImageFrame::N32, ImageFrame::Index8 };
+    for (ImageFrame::ColorType targetType : targetTypes) {
+        RefPtr<SharedBuffer> fullData = readFile(layoutTestResourcesDir, "animated-10color.gif");
+        ASSERT_TRUE(fullData.get());
+        Vector<unsigned> baselineHashes;
+        createDecodingBaseline(&createDecoder, fullData.get(), &baselineHashes, targetType);
+        size_t frameCount = baselineHashes.size();
+
+        OwnPtr<ImageDecoder> decoder = createDecoder();
+
+        // Let frame 0 be partially decoded.
+        size_t partialSize = 1;
+        do {
+            RefPtr<SharedBuffer> data = SharedBuffer::create(fullData->data(), partialSize);
+            decoder->setData(data.get(), false);
+            ++partialSize;
+        } while (!decoder->frameCount() || decoder->frameBufferAtIndex(0, targetType)->status() == ImageFrame::FrameEmpty);
+
+        // Skip to the last frame and clear.
+        decoder->setData(fullData.get(), true);
+        EXPECT_EQ(frameCount, decoder->frameCount());
+        ImageFrame* lastFrame = decoder->frameBufferAtIndex(frameCount - 1, targetType);
+        EXPECT_EQ(baselineHashes[frameCount - 1], hashBitmap(lastFrame->getSkBitmap()));
+        decoder->clearCacheExceptFrame(kNotFound);
+
+        // Resume decoding of the first frame.
+        ImageFrame* firstFrame = decoder->frameBufferAtIndex(0, targetType);
+        EXPECT_EQ(ImageFrame::FrameComplete, firstFrame->status());
+        EXPECT_EQ(baselineHashes[0], hashBitmap(firstFrame->getSkBitmap()));
+    }
 }
 
 // The first LZW codes in the image are invalid values that try to create a loop
@@ -501,4 +648,31 @@ TEST(GIFImageDecoderTest, firstFrameHasGreaterSizeThanScreenSize)
     }
 }
 
+#define BENCHMARK_DECODE(dir, file, title, count)\
+TEST(GIFImageDecoderTest, tempBench_decodeIndex8##title##warmuprun)\
+{\
+    testRandomDecodeAfterClearFrameBufferCache(dir, file);\
+}\
+TEST(GIFImageDecoderTest, tempBench_decodeN32##title##_x##count) \
+{\
+    for (int i = 0; i < count; ++i)\
+        testRandomDecodeAfterClearFrameBufferCache(dir, file);\
+}\
+\
+TEST(GIFImageDecoderTest, tempBench_decodeIndex8##title##_x##count)\
+{\
+    for (int i = 0; i < count; ++i)\
+        testRandomDecodeAfterClearFrameBufferCache(dir, file, ImageFrame::Index8);\
+}\
+
+BENCHMARK_DECODE(layoutTestResourcesDir, "animated-10color.gif", animated_10color_gif, 5)
+BENCHMARK_DECODE(webTestsDataDir, "radient.gif", radient_gif, 10)
+BENCHMARK_DECODE(layoutTestResourcesDir, "animated-gif-with-offsets.gif", animated_gif_with_offsets_gif, 5)
+BENCHMARK_DECODE(layoutTestResourcesDir, "animated.gif", animated_gif, 10)
+BENCHMARK_DECODE(layoutTestResourcesDir, "quicksort.gif", quicksort_gif, 5)
+BENCHMARK_DECODE(layoutTestResourcesDir, "large-gif-checkerboard.gif", large_gif_checkerboard_gif, 5)
+BENCHMARK_DECODE(layoutTestResourcesDir, "3dolph.gif", 3dolph_gif, 5)
+// BENCHMARK_DECODE(layoutTestResourcesDir, "disneypixar-disney-pixar-jTXvL4LjakYI8.gif", disneypixar_disney_pixar_jTXvL4LjakYI8_gif, 1)
+// BENCHMARK_DECODE(webTestsDataDir, "issue_476531_AqLvXJh.gif", issue_476531_AqLvXJh_gif, 1)
+
 } // namespace blink