runtime/vm/flow_graph_compiler_arm.cc - Issue 14605006: Allows "Hello, world!" to run on ARM hardware.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 14605006: Allows "Hello, world!" to run on ARM hardware. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_arm.cc

===================================================================

--- runtime/vm/flow_graph_compiler_arm.cc (revision 22334)

+++ runtime/vm/flow_graph_compiler_arm.cc (working copy)

@@ -1193,7 +1193,9 @@

// lowest address.

const intptr_t cpu_registers = locs->live_registers()->cpu_registers();

ASSERT((cpu_registers & ~kAllCpuRegistersList) == 0);

- __ PushList(cpu_registers);

+ if (cpu_registers != 0) {

+ __ PushList(cpu_registers);

+ }

}

@@ -1202,7 +1204,9 @@

// lowest address.

const intptr_t cpu_registers = locs->live_registers()->cpu_registers();

ASSERT((cpu_registers & ~kAllCpuRegistersList) == 0);

- __ PopList(cpu_registers);

+ if (cpu_registers != 0) {

+ __ PopList(cpu_registers);

+ }

const intptr_t fpu_registers = locs->live_registers()->fpu_registers();

if (fpu_registers > 0) {

« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »