mojo/public/cpp/bindings/tests/router_unittest.cc - Issue 1460463003: Move mojo::internal::MessageBuilder out of the |internal| namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/router_unittest.cc

Issue 1460463003: Move mojo::internal::MessageBuilder out of the |internal| namespace. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: formatting + style changes (from trung comments) Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/message_builder_unittest.cc ('k') | mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/tests/router_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/router_unittest.cc b/mojo/public/cpp/bindings/tests/router_unittest.cc

index 541af01e83d0fc1d6bd6cde41e7015c674e4bb09..c757b3107fdf759bdac1fd4fc0efa370e4d8aff9 100644

--- a/mojo/public/cpp/bindings/tests/router_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/router_unittest.cc

@@ -19,7 +19,7 @@ namespace {

void AllocRequestMessage(uint32_t name, const char* text, Message* message) {

size_t payload_size = strlen(text) + 1; // Plus null terminator.

- internal::RequestMessageBuilder builder(name, payload_size);

+ RequestMessageBuilder builder(name, payload_size);

memcpy(builder.buffer()->Allocate(payload_size), text, payload_size);

builder.message()->MoveTo(message);

@@ -30,7 +30,7 @@ void AllocResponseMessage(uint32_t name,

uint64_t request_id,

Message* message) {

size_t payload_size = strlen(text) + 1; // Plus null terminator.

- internal::ResponseMessageBuilder builder(name, payload_size, request_id);

+ ResponseMessageBuilder builder(name, payload_size, request_id);

memcpy(builder.buffer()->Allocate(payload_size), text, payload_size);

builder.message()->MoveTo(message);