Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1522)

Unified Diff: mojo/public/cpp/bindings/tests/connector_unittest.cc

Issue 1460463003: Move mojo::internal::MessageBuilder out of the |internal| namespace. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: formatting + style changes (from trung comments) Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/bindings/tests/BUILD.gn ('k') | mojo/public/cpp/bindings/tests/message_builder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/tests/connector_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/connector_unittest.cc b/mojo/public/cpp/bindings/tests/connector_unittest.cc
index c236d40e9852ab42417de3eb71bb833d958cdb25..a85d8d323c5a4b45169b23aac60b1f454202d5b1 100644
--- a/mojo/public/cpp/bindings/tests/connector_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/connector_unittest.cc
@@ -36,7 +36,7 @@ class MessageAccumulator : public MessageReceiver {
class ConnectorDeletingMessageAccumulator : public MessageAccumulator {
public:
- ConnectorDeletingMessageAccumulator(internal::Connector** connector)
+ explicit ConnectorDeletingMessageAccumulator(internal::Connector** connector)
: connector_(connector) {}
bool Accept(Message* message) override {
@@ -51,7 +51,7 @@ class ConnectorDeletingMessageAccumulator : public MessageAccumulator {
class ReentrantMessageAccumulator : public MessageAccumulator {
public:
- ReentrantMessageAccumulator(internal::Connector* connector)
+ explicit ReentrantMessageAccumulator(internal::Connector* connector)
: connector_(connector), number_of_calls_(0) {}
bool Accept(Message* message) override {
@@ -83,7 +83,7 @@ class ConnectorTest : public testing::Test {
void AllocMessage(const char* text, Message* message) {
size_t payload_size = strlen(text) + 1; // Plus null terminator.
- internal::MessageBuilder builder(1, payload_size);
+ MessageBuilder builder(1, payload_size);
memcpy(builder.buffer()->Allocate(payload_size), text, payload_size);
builder.message()->MoveTo(message);
« no previous file with comments | « mojo/public/cpp/bindings/tests/BUILD.gn ('k') | mojo/public/cpp/bindings/tests/message_builder_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698