Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: mojo/public/cpp/bindings/lib/message_builder.cc

Issue 1460463003: Move mojo::internal::MessageBuilder out of the |internal| namespace. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: formatting + style changes (from trung comments) Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/bindings/lib/message_builder.h ('k') | mojo/public/cpp/bindings/tests/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/lib/message_builder.cc
diff --git a/mojo/public/cpp/bindings/lib/message_builder.cc b/mojo/public/cpp/bindings/lib/message_builder.cc
index 25f1862e47ea8b1fba531f70cd5a0ebbd7eaa332..a49dc84a8ccf8eda12bdbcde236f79d79eb1f52b 100644
--- a/mojo/public/cpp/bindings/lib/message_builder.cc
+++ b/mojo/public/cpp/bindings/lib/message_builder.cc
@@ -8,14 +8,35 @@
#include "mojo/public/cpp/bindings/message.h"
namespace mojo {
-namespace internal {
+namespace {
+using internal::MessageHeader;
+using internal::MessageHeaderWithRequestID;
template <typename Header>
-void Allocate(Buffer* buf, Header** header) {
+void Allocate(internal::Buffer* buf, Header** header) {
*header = static_cast<Header*>(buf->Allocate(sizeof(Header)));
(*header)->num_bytes = sizeof(Header);
}
+} // namespace
+
+namespace internal {
+
+MessageWithRequestIDBuilder::MessageWithRequestIDBuilder(uint32_t name,
+ size_t payload_size,
+ uint32_t flags,
+ uint64_t request_id) {
+ Initialize(sizeof(MessageHeaderWithRequestID) + payload_size);
+ MessageHeaderWithRequestID* header;
+ Allocate(&buf_, &header);
+ header->version = 1;
+ header->name = name;
+ header->flags = flags;
+ header->request_id = request_id;
+}
+
+} // namespace internal
+
MessageBuilder::MessageBuilder(uint32_t name, size_t payload_size) {
Initialize(sizeof(MessageHeader) + payload_size);
@@ -23,6 +44,7 @@ MessageBuilder::MessageBuilder(uint32_t name, size_t payload_size) {
Allocate(&buf_, &header);
header->version = 0;
header->name = name;
+ header->flags = 0;
}
MessageBuilder::~MessageBuilder() {
@@ -31,22 +53,8 @@ MessageBuilder::~MessageBuilder() {
MessageBuilder::MessageBuilder() {}
void MessageBuilder::Initialize(size_t size) {
- message_.AllocData(static_cast<uint32_t>(Align(size)));
+ message_.AllocData(static_cast<uint32_t>(internal::Align(size)));
buf_.Initialize(message_.mutable_data(), message_.data_num_bytes());
}
-MessageWithRequestIDBuilder::MessageWithRequestIDBuilder(uint32_t name,
- size_t payload_size,
- uint32_t flags,
- uint64_t request_id) {
- Initialize(sizeof(MessageHeaderWithRequestID) + payload_size);
- MessageHeaderWithRequestID* header;
- Allocate(&buf_, &header);
- header->version = 1;
- header->name = name;
- header->flags = flags;
- header->request_id = request_id;
-}
-
-} // namespace internal
} // namespace mojo
« no previous file with comments | « mojo/public/cpp/bindings/lib/message_builder.h ('k') | mojo/public/cpp/bindings/tests/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698