Move mojo::internal::MessageBuilder out of the |internal| namespace.

mojo/public/cpp/bindings/lib/message_builder.cc

Index: mojo/public/cpp/bindings/lib/message_builder.cc
diff --git a/mojo/public/cpp/bindings/lib/message_builder.cc b/mojo/public/cpp/bindings/lib/message_builder.cc
index 25f1862e47ea8b1fba531f70cd5a0ebbd7eaa332..ed9301df5ea3c4647352bb1729798ffd66c4cc6c 100644
--- a/mojo/public/cpp/bindings/lib/message_builder.cc
+++ b/mojo/public/cpp/bindings/lib/message_builder.cc
@@ -8,13 +8,31 @@
 #include "mojo/public/cpp/bindings/message.h"
 
 namespace mojo {
-namespace internal {
+namespace {
+using internal::MessageHeader;
+using internal::MessageHeaderWithRequestID;
 
 template <typename Header>
-void Allocate(Buffer* buf, Header** header) {
+void Allocate(internal::Buffer* buf, Header** header) {
   *header = static_cast<Header*>(buf->Allocate(sizeof(Header)));
   (*header)->num_bytes = sizeof(Header);
 }
+}  // namespace

[viettrungluu, 2015/11/18 23:55:59]

And there should be a blank line before this.

+
+namespace internal {
+MessageWithRequestIDBuilder::MessageWithRequestIDBuilder(uint32_t name,
+                                                         size_t payload_size,
+                                                         uint32_t flags,
+                                                         uint64_t request_id) {
+  Initialize(sizeof(MessageHeaderWithRequestID) + payload_size);
+  MessageHeaderWithRequestID* header;
+  Allocate(&buf_, &header);
+  header->version = 1;
+  header->name = name;
+  header->flags = flags;
+  header->request_id = request_id;
+}
+}  // namespace internal
 
 MessageBuilder::MessageBuilder(uint32_t name, size_t payload_size) {
   Initialize(sizeof(MessageHeader) + payload_size);
@@ -23,6 +41,7 @@ MessageBuilder::MessageBuilder(uint32_t name, size_t payload_size) {
   Allocate(&buf_, &header);
   header->version = 0;
   header->name = name;
+  header->flags = 0;
 }
 
 MessageBuilder::~MessageBuilder() {
@@ -31,22 +50,7 @@ MessageBuilder::~MessageBuilder() {
 MessageBuilder::MessageBuilder() {}
 
 void MessageBuilder::Initialize(size_t size) {
-  message_.AllocData(static_cast<uint32_t>(Align(size)));
+  message_.AllocData(static_cast<uint32_t>(internal::Align(size)));
   buf_.Initialize(message_.mutable_data(), message_.data_num_bytes());
 }
-
-MessageWithRequestIDBuilder::MessageWithRequestIDBuilder(uint32_t name,
-                                                         size_t payload_size,
-                                                         uint32_t flags,
-                                                         uint64_t request_id) {
-  Initialize(sizeof(MessageHeaderWithRequestID) + payload_size);
-  MessageHeaderWithRequestID* header;
-  Allocate(&buf_, &header);
-  header->version = 1;
-  header->name = name;
-  header->flags = flags;
-  header->request_id = request_id;
-}
-
-}  // namespace internal
 }  // namespace mojo