Move mojo::internal::MessageBuilder out of the |internal| namespace.

mojo/public/cpp/bindings/tests/message_builder_unittest.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "mojo/public/cpp/bindings/lib/bindings_serialization.h"
+#include "mojo/public/cpp/bindings/lib/message_builder.h"
+#include "mojo/public/cpp/bindings/lib/message_internal.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace mojo {
+namespace test {
+namespace {
+
+// Tests the Message built from using the MessageBuilder class.

[viettrungluu, 2015/11/18 23:55:59]

nit: You can probably omit comments like this (which fall into the same category
as commenting "GetFoo()" with a comment saying "Gets Foo.").

+TEST(MessageBuilderTest, MessageBuilder) {
+  char payload[41];
+  MessageBuilder b(123u, sizeof(payload));
+
+  // The payload should be 8-byte aligned.

[viettrungluu, 2015/11/18 23:55:59]

nit: "8-byte aligned" is not what you mean. You mean, "should be a multiple of 8
bytes in size". (Alignment is about the (starting) address not the size.)

+  EXPECT_EQ(48u, b.message()->payload_num_bytes());
+
+  // payload size + message header size:
+  EXPECT_EQ(48u + sizeof(internal::MessageHeader),
+            b.message()->data_num_bytes());
+
+  const auto* msg_hdr =
+      reinterpret_cast<const internal::MessageHeader*>(b.message()->data());
+  EXPECT_EQ(123u, msg_hdr->name);
+  EXPECT_EQ(0u, msg_hdr->flags);
+  EXPECT_EQ(0u, msg_hdr->version);
+
+  EXPECT_EQ(sizeof(internal::MessageHeader), msg_hdr->num_bytes);
+}
+
+// Tests the Message built from using the RequestMessageBuilder class.

[viettrungluu, 2015/11/18 23:55:59]

Etc.

+TEST(MessageBuilderTest, RequestMessageBuilder) {
+  char payload[41];
+  RequestMessageBuilder b(123u, sizeof(payload));
+
+  // The payload should be 8-byte aligned.
+  EXPECT_EQ(48u, b.message()->payload_num_bytes());
+  // Total data size should be payload size + message header size.
+  EXPECT_EQ(48u + sizeof(internal::MessageHeaderWithRequestID),
+            b.message()->data_num_bytes());
+
+  const auto* msg_hdr =
+      reinterpret_cast<const internal::MessageHeaderWithRequestID*>(
+          b.message()->data());
+  EXPECT_EQ(123u, msg_hdr->name);
+  EXPECT_EQ(internal::kMessageExpectsResponse, msg_hdr->flags);
+  EXPECT_EQ(1u, msg_hdr->version);
+  EXPECT_EQ(0ul, msg_hdr->request_id);
+  EXPECT_EQ(sizeof(internal::MessageHeaderWithRequestID), msg_hdr->num_bytes);
+}
+
+// Tests the Message built from using the ResponseMessageBuilder class.
+TEST(MessageBuilderTest, ResponseMessageBuilder) {
+  char payload[41];
+  ResponseMessageBuilder b(123u, sizeof(payload), 0ull);
+  // The payload should be 8-byte aligned.
+  EXPECT_EQ(48u, b.message()->payload_num_bytes());
+
+  // Total data size should be payload size + message header size.
+  EXPECT_EQ(48u + sizeof(internal::MessageHeaderWithRequestID),
+            b.message()->data_num_bytes());
+
+  const auto* msg_hdr =
+      reinterpret_cast<const internal::MessageHeaderWithRequestID*>(
+          b.message()->data());
+  EXPECT_EQ(123u, msg_hdr->name);
+  EXPECT_EQ(internal::kMessageIsResponse, msg_hdr->flags);
+  EXPECT_EQ(1u, msg_hdr->version);
+  EXPECT_EQ(0ul, msg_hdr->request_id);
+  EXPECT_EQ(sizeof(internal::MessageHeaderWithRequestID), msg_hdr->num_bytes);
+}
+
+}  // namespace
+}  // namespace test
+}  // namespace mojo