Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Side by Side Diff: mojo/public/cpp/bindings/tests/connector_unittest.cc

Issue 1460463003: Move mojo::internal::MessageBuilder out of the |internal| namespace. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: More comments for MessageBuilder + a unittest. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdlib.h> 5 #include <stdlib.h>
6 #include <string.h> 6 #include <string.h>
7 7
8 #include "mojo/public/cpp/bindings/lib/connector.h" 8 #include "mojo/public/cpp/bindings/lib/connector.h"
9 #include "mojo/public/cpp/bindings/lib/message_builder.h" 9 #include "mojo/public/cpp/bindings/lib/message_builder.h"
10 #include "mojo/public/cpp/bindings/tests/message_queue.h" 10 #include "mojo/public/cpp/bindings/tests/message_queue.h"
(...skipping 18 matching lines...) Expand all
29 bool IsEmpty() const { return queue_.IsEmpty(); } 29 bool IsEmpty() const { return queue_.IsEmpty(); }
30 30
31 void Pop(Message* message) { queue_.Pop(message); } 31 void Pop(Message* message) { queue_.Pop(message); }
32 32
33 private: 33 private:
34 MessageQueue queue_; 34 MessageQueue queue_;
35 }; 35 };
36 36
37 class ConnectorDeletingMessageAccumulator : public MessageAccumulator { 37 class ConnectorDeletingMessageAccumulator : public MessageAccumulator {
38 public: 38 public:
39 ConnectorDeletingMessageAccumulator(internal::Connector** connector) 39 explicit ConnectorDeletingMessageAccumulator(internal::Connector** connector)
40 : connector_(connector) {} 40 : connector_(connector) {}
41 41
42 bool Accept(Message* message) override { 42 bool Accept(Message* message) override {
43 delete *connector_; 43 delete *connector_;
44 *connector_ = 0; 44 *connector_ = 0;
45 return MessageAccumulator::Accept(message); 45 return MessageAccumulator::Accept(message);
46 } 46 }
47 47
48 private: 48 private:
49 internal::Connector** connector_; 49 internal::Connector** connector_;
50 }; 50 };
51 51
52 class ReentrantMessageAccumulator : public MessageAccumulator { 52 class ReentrantMessageAccumulator : public MessageAccumulator {
53 public: 53 public:
54 ReentrantMessageAccumulator(internal::Connector* connector) 54 explicit ReentrantMessageAccumulator(internal::Connector* connector)
55 : connector_(connector), number_of_calls_(0) {} 55 : connector_(connector), number_of_calls_(0) {}
56 56
57 bool Accept(Message* message) override { 57 bool Accept(Message* message) override {
58 if (!MessageAccumulator::Accept(message)) 58 if (!MessageAccumulator::Accept(message))
59 return false; 59 return false;
60 number_of_calls_++; 60 number_of_calls_++;
61 if (number_of_calls_ == 1) { 61 if (number_of_calls_ == 1) {
62 return connector_->WaitForIncomingMessage(MOJO_DEADLINE_INDEFINITE); 62 return connector_->WaitForIncomingMessage(MOJO_DEADLINE_INDEFINITE);
63 } 63 }
64 return true; 64 return true;
(...skipping 11 matching lines...) Expand all
76 ConnectorTest() {} 76 ConnectorTest() {}
77 77
78 void SetUp() override { 78 void SetUp() override {
79 CreateMessagePipe(nullptr, &handle0_, &handle1_); 79 CreateMessagePipe(nullptr, &handle0_, &handle1_);
80 } 80 }
81 81
82 void TearDown() override {} 82 void TearDown() override {}
83 83
84 void AllocMessage(const char* text, Message* message) { 84 void AllocMessage(const char* text, Message* message) {
85 size_t payload_size = strlen(text) + 1; // Plus null terminator. 85 size_t payload_size = strlen(text) + 1; // Plus null terminator.
86 internal::MessageBuilder builder(1, payload_size); 86 MessageBuilder builder(1, payload_size);
87 memcpy(builder.buffer()->Allocate(payload_size), text, payload_size); 87 memcpy(builder.buffer()->Allocate(payload_size), text, payload_size);
88 88
89 builder.message()->MoveTo(message); 89 builder.message()->MoveTo(message);
90 } 90 }
91 91
92 void PumpMessages() { loop_.RunUntilIdle(); } 92 void PumpMessages() { loop_.RunUntilIdle(); }
93 93
94 protected: 94 protected:
95 ScopedMessagePipeHandle handle0_; 95 ScopedMessagePipeHandle handle0_;
96 ScopedMessagePipeHandle handle1_; 96 ScopedMessagePipeHandle handle1_;
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 std::string(kText[i]), 386 std::string(kText[i]),
387 std::string(reinterpret_cast<const char*>(message_received.payload()))); 387 std::string(reinterpret_cast<const char*>(message_received.payload())));
388 } 388 }
389 389
390 ASSERT_EQ(2, accumulator.number_of_calls()); 390 ASSERT_EQ(2, accumulator.number_of_calls());
391 } 391 }
392 392
393 } // namespace 393 } // namespace
394 } // namespace test 394 } // namespace test
395 } // namespace mojo 395 } // namespace mojo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698