Move mojo::internal::MessageBuilder out of the |internal| namespace.

mojo/public/cpp/bindings/lib/message_builder.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// These are helper classes for allocating, aligning, and framing a
+// |mojo::Message|. They are mainly used from within the generated C++ bindings.
+
 #ifndef MOJO_PUBLIC_CPP_BINDINGS_LIB_MESSAGE_BUILDER_H_
 #define MOJO_PUBLIC_CPP_BINDINGS_LIB_MESSAGE_BUILDER_H_
 
 #include <stdint.h>
 
 #include "mojo/public/cpp/bindings/lib/fixed_buffer.h"
 #include "mojo/public/cpp/bindings/lib/message_internal.h"
 #include "mojo/public/cpp/bindings/message.h"
 
 namespace mojo {
 class Message;
 
-namespace internal {
-
+// MessageBuilder helps initialize and frame a |mojo::Message| which does not

[viettrungluu, 2015/11/18 23:55:59]

nit: "which" -> "that"

+// expect a response message, and therefore does not tag the message with a
+// request id (which may save some bytes).
+//
+// The underlying |Message| is owned by MessageBuilder, but can be permanently
+// moved by calling accessing |message()| and calling its |MoveTo()|.
 class MessageBuilder {
  public:
+  // This frames and configures a |mojo::Message| with the given message name.
   MessageBuilder(uint32_t name, size_t payload_size);
   ~MessageBuilder();
 
-  Buffer* buffer() { return &buf_; }
   Message* message() { return &message_; }
 
+  // TODO(vardhan): |buffer()| is internal and only consumed by internal classes
+  // and unittests.  Consider making it private + friend class its consumers?
+  internal::Buffer* buffer() { return &buf_; }
+
  protected:
   MessageBuilder();
   void Initialize(size_t size);
 
   Message message_;
-  FixedBuffer buf_;
+  internal::FixedBuffer buf_;
 
   MOJO_DISALLOW_COPY_AND_ASSIGN(MessageBuilder);
 };
 
+namespace internal {

[viettrungluu, 2015/11/18 23:55:59]

nit:

Generally, there should be a blank line following |namespace foo {|, unless:
* The following line is just |namespace bar {|.
* You're just forward declaring something(s).

Similarly, there should be a blank line before |}  // namespace foo|, unless the
previous line was |}  // namespace bar| or the "body" consisted only of forward
declarations.

 class MessageWithRequestIDBuilder : public MessageBuilder {
  public:
   MessageWithRequestIDBuilder(uint32_t name,
                               size_t payload_size,
                               uint32_t flags,
                               uint64_t request_id);
 };
+}  // namespace internal
 
-class RequestMessageBuilder : public MessageWithRequestIDBuilder {
+// Builds a |mojo::Message| that is a "request" message, which expects a

[viettrungluu, 2015/11/18 23:55:59]

nit: ", which" -> " that" (no comma)

+// response message. You can give it a unique |request_id| (with which you can
+// construct a response message) by calling |message()->set_request_id()|.
+//
+// Has the same interface as |mojo::MessageBuilder|.
+class RequestMessageBuilder : public internal::MessageWithRequestIDBuilder {
  public:
   RequestMessageBuilder(uint32_t name, size_t payload_size)
       : MessageWithRequestIDBuilder(name,
                                     payload_size,
-                                    kMessageExpectsResponse,
+                                    internal::kMessageExpectsResponse,
                                     0) {}
 };
 
-class ResponseMessageBuilder : public MessageWithRequestIDBuilder {
+// Builds a |mojo::Message| that is a "response" message which pertains to a
+// |request_id|.
+//
+// Has the same interface as |mojo::MessageBuilder|.
+class ResponseMessageBuilder : public internal::MessageWithRequestIDBuilder {
  public:
   ResponseMessageBuilder(uint32_t name,
                          size_t payload_size,
                          uint64_t request_id)
       : MessageWithRequestIDBuilder(name,
                                     payload_size,
-                                    kMessageIsResponse,
+                                    internal::kMessageIsResponse,
                                     request_id) {}
 };
 
-}  // namespace internal
 }  // namespace mojo
 
 #endif  // MOJO_PUBLIC_CPP_BINDINGS_LIB_MESSAGE_BUILDER_H_