Move mojo::internal::MessageBuilder out of the |internal| namespace.

mojo/public/cpp/bindings/lib/message_builder.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_PUBLIC_CPP_BINDINGS_LIB_MESSAGE_BUILDER_H_
 #define MOJO_PUBLIC_CPP_BINDINGS_LIB_MESSAGE_BUILDER_H_
 
 #include <stdint.h>
 
 #include "mojo/public/cpp/bindings/lib/fixed_buffer.h"
 #include "mojo/public/cpp/bindings/lib/message_internal.h"
 #include "mojo/public/cpp/bindings/message.h"
 
 namespace mojo {
 class Message;
 
-namespace internal {
-
 class MessageBuilder {

[viettrungluu, 2015/11/17 23:59:38]

Are there specific tests for MessageBuilder, MessageWithRequestIDBuilder, etc.?
(If not, you should probably add some. :P)

[vardhan, 2015/11/18 22:46:40]

Done.

  public:
   MessageBuilder(uint32_t name, size_t payload_size);
   ~MessageBuilder();
 
-  Buffer* buffer() { return &buf_; }
+  // TODO(vardhan): |buffer()| is internal and only consumed by internal classes

[viettrungluu, 2015/11/17 23:59:38]

Maybe, in light of this comment, you should put this after |message()|?

[vardhan, 2015/11/18 22:46:40]

Done.

+  // and unittests.  Consider making it private + friend class its consumers?
+  internal::Buffer* buffer() { return &buf_; }
   Message* message() { return &message_; }
 
  protected:
   MessageBuilder();
   void Initialize(size_t size);
 
   Message message_;
-  FixedBuffer buf_;
+  internal::FixedBuffer buf_;
 
   MOJO_DISALLOW_COPY_AND_ASSIGN(MessageBuilder);
 };
 
 class MessageWithRequestIDBuilder : public MessageBuilder {
  public:
   MessageWithRequestIDBuilder(uint32_t name,
                               size_t payload_size,
                               uint32_t flags,
                               uint64_t request_id);
 };
 
 class RequestMessageBuilder : public MessageWithRequestIDBuilder {
  public:
   RequestMessageBuilder(uint32_t name, size_t payload_size)
       : MessageWithRequestIDBuilder(name,
                                     payload_size,
-                                    kMessageExpectsResponse,
+                                    internal::kMessageExpectsResponse,
                                     0) {}
 };
 
 class ResponseMessageBuilder : public MessageWithRequestIDBuilder {
  public:
   ResponseMessageBuilder(uint32_t name,
                          size_t payload_size,
                          uint64_t request_id)
       : MessageWithRequestIDBuilder(name,
                                     payload_size,
-                                    kMessageIsResponse,
+                                    internal::kMessageIsResponse,
                                     request_id) {}
 };
 
-}  // namespace internal
 }  // namespace mojo
 
 #endif  // MOJO_PUBLIC_CPP_BINDINGS_LIB_MESSAGE_BUILDER_H_