Move mojo::internal::MessageBuilder out of the |internal| namespace.

mojo/public/cpp/bindings/lib/message_builder.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/public/cpp/bindings/lib/message_builder.h"
 
 #include "mojo/public/cpp/bindings/lib/bindings_serialization.h"
 #include "mojo/public/cpp/bindings/message.h"
 
 namespace mojo {
-namespace internal {
+

[viettrungluu, 2015/11/18 23:55:59]

It's debatable if you should delete this blank line (depending on if you believe
the rule about omitting blank line applies to totally nested pairs/triples/etc.
of namespaces or to the partial case as well).

+namespace {
+

[viettrungluu, 2015/11/18 23:55:59]

So you shouldn't delete this blank line.

+using internal::MessageHeader;
+using internal::MessageHeaderWithRequestID;
 
 template <typename Header>
-void Allocate(Buffer* buf, Header** header) {
+void Allocate(internal::Buffer* buf, Header** header) {
   *header = static_cast<Header*>(buf->Allocate(sizeof(Header)));
   (*header)->num_bytes = sizeof(Header);
 }
 
+}  // namespace
+
 MessageBuilder::MessageBuilder(uint32_t name, size_t payload_size) {
   Initialize(sizeof(MessageHeader) + payload_size);
 
   MessageHeader* header;
   Allocate(&buf_, &header);
   header->version = 0;
   header->name = name;
+  header->flags = 0;

[viettrungluu, 2015/11/17 23:59:38]

I guess Allocate() (that is, internal::Buffer::Allocate()) already
zero-initializes, so what was there before wasn't actually wrong. <shrug>

[vardhan, 2015/11/18 22:46:40]

I think it's because we should explicitly set a default (defensive programming?)
also, it might be why header->version was already set to 0.

[viettrungluu, 2015/11/18 23:55:59]

(I wasn't actually disagreeing with setting it explicitly.)

 }
 
 MessageBuilder::~MessageBuilder() {
 }
 
 MessageBuilder::MessageBuilder() {}
 
 void MessageBuilder::Initialize(size_t size) {
-  message_.AllocData(static_cast<uint32_t>(Align(size)));
+  message_.AllocData(static_cast<uint32_t>(internal::Align(size)));
   buf_.Initialize(message_.mutable_data(), message_.data_num_bytes());
 }
 
 MessageWithRequestIDBuilder::MessageWithRequestIDBuilder(uint32_t name,
                                                          size_t payload_size,
                                                          uint32_t flags,
                                                          uint64_t request_id) {
   Initialize(sizeof(MessageHeaderWithRequestID) + payload_size);
   MessageHeaderWithRequestID* header;
   Allocate(&buf_, &header);
   header->version = 1;
   header->name = name;
   header->flags = flags;
   header->request_id = request_id;
 }
 
-}  // namespace internal
 }  // namespace mojo