Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1460433002: [DevTools] Persist device mode state. (Closed)

Created:
5 years, 1 month ago by dgozman
Modified:
5 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Persist device mode state. Drive-by: fixed a reset-on-reload bug. BUG=540864, 556651 Committed: https://crrev.com/773343d7f8634cff5b6ff9159917c0e3d8261562 Cr-Commit-Position: refs/heads/master@{#360157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 5 chunks +52 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/OverridesSupport.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dgozman
PTAL
5 years, 1 month ago (2015-11-17 19:35:59 UTC) #2
pfeldman
lgtm
5 years, 1 month ago (2015-11-17 19:36:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460433002/1
5 years, 1 month ago (2015-11-17 19:37:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 20:52:20 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 20:53:16 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/773343d7f8634cff5b6ff9159917c0e3d8261562
Cr-Commit-Position: refs/heads/master@{#360157}

Powered by Google App Engine
This is Rietveld 408576698