Issue 146043008: Verify that appendChild(script) does not perform a microtask checkpoint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146043008: Verify that appendChild(script) does not perform a microtask checkpoint (Closed)

Created:
6 years, 10 months ago by philipj_slow

Modified:
6 years, 10 months ago

Reviewers:
tkent, esprehn, adamk, rafaelw, eseidel

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Verify that appendChild(script) does not perform a microtask checkpoint This potential bug was raised in the review for the previous patch: https://codereview.chromium.org/130983011/ BUG=340322 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166962

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -5 lines)			Patch
A +	LayoutTests/fast/dom/MutationObserver/script-append.html	View	2 chunks	+8 lines, -3 lines	0 comments	Download
A +	LayoutTests/fast/dom/MutationObserver/script-append-expected.txt	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	Source/core/html/parser/HTMLScriptRunner.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

philipj_slow

Sending before the try bots have finished, hoping that I'm right on this :)

6 years, 10 months ago (2014-02-11 03:37:59 UTC) #1

adamk

lgtm Thanks for the test, more coverage here makes me happy.

6 years, 10 months ago (2014-02-11 19:03:42 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/146043008/1

6 years, 10 months ago (2014-02-12 04:01:03 UTC) #4

Message was sent while issue was closed.

Change committed as 166962