Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Side by Side Diff: third_party/libxml/libxml.gyp

Issue 146043003: Start massaging the GYP files for building with clang on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« build/common.gypi ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'conditions': [ 7 'conditions': [
8 # Define an "os_include" variable that points at the OS-specific generated 8 # Define an "os_include" variable that points at the OS-specific generated
9 # headers. These were generated by running the configure script offline. 9 # headers. These were generated by running the configure script offline.
10 ['os_posix == 1 and OS != "mac" and OS != "ios"', { 10 ['os_posix == 1 and OS != "mac" and OS != "ios"', {
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 ['OS=="win"', { 226 ['OS=="win"', {
227 'product_name': 'libxml2', 227 'product_name': 'libxml2',
228 # Disable unimportant 'unused variable' warning, and 228 # Disable unimportant 'unused variable' warning, and
229 # signed/unsigned comparison warning. The signed/unsigned (4101) 229 # signed/unsigned comparison warning. The signed/unsigned (4101)
230 # is fixed upstream and can be removed eventually. 230 # is fixed upstream and can be removed eventually.
231 # TODO(jschuh): http://crbug.com/167187 size_t -> int 231 # TODO(jschuh): http://crbug.com/167187 size_t -> int
232 'msvs_disabled_warnings': [ 4018, 4101, 4267 ], 232 'msvs_disabled_warnings': [ 4018, 4101, 4267 ],
233 }, { # else: OS!="win" 233 }, { # else: OS!="win"
234 'product_name': 'xml2', 234 'product_name': 'xml2',
235 }], 235 }],
236 ['clang == 1', { 236 ['clang==1', {
237 'xcode_settings': { 237 'xcode_settings': {
238 'WARNING_CFLAGS': [ 238 'WARNING_CFLAGS': [
239 # libxml passes `const unsigned char*` through `const char*`. 239 # libxml passes `const unsigned char*` through `const char*`.
240 '-Wno-pointer-sign', 240 '-Wno-pointer-sign',
241 # pattern.c and uri.c both have an intentional 241 # pattern.c and uri.c both have an intentional
242 # `for (...);` / `while(...);` loop. I submitted a patch to 242 # `for (...);` / `while(...);` loop. I submitted a patch to
243 # move the `'` to its own line, but until that's landed 243 # move the `'` to its own line, but until that's landed
244 # suppress the warning: 244 # suppress the warning:
245 '-Wno-empty-body', 245 '-Wno-empty-body',
246 ], 246 ],
247 }, 247 },
248 'cflags': [ 248 'cflags': [
249 '-Wno-pointer-sign', 249 '-Wno-pointer-sign',
250 '-Wno-empty-body', 250 '-Wno-empty-body',
251 251
252 # See http://crbug.com/138571#c8 252 # See http://crbug.com/138571#c8
253 '-Wno-ignored-attributes', 253 '-Wno-ignored-attributes',
254 ], 254 ],
255 'msvs_settings': {
256 'VCCLCompilerTool': {
257 'AdditionalOptions': [
258 # VS2012's standard lib doesn't provide nan().
259 '/U__STDC_VERSION__',
260 ],
261 },
262 },
255 }], 263 }],
256 ], 264 ],
257 }], 265 }],
258 ], 266 ],
259 }, 267 },
260 ], 268 ],
261 } 269 }
OLDNEW
« build/common.gypi ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698