Issue 14604011: Separate the PNaCl llc into a tool named pnacl-llc (how original!)

Issue 14604011: Separate the PNaCl llc into a tool named pnacl-llc (how original!) (Closed)

Created:
7 years, 7 months ago by eliben

Modified:
7 years, 7 months ago

Reviewers:
jvoung (off chromium), Mark Seaborn, Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master

Visibility:
Public.

More Reviews

Description

Separate the PNaCl llc into a tool named pnacl-llc (how original!) BUG=None R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=28aeda4

Patch Set 2 : Review comments #

Total comments: 2

Patch Set 3 : Remove dangling LOCALMOD-BEGIN #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -97 lines)			Patch
M	tools/CMakeLists.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/LLVMBuild.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	tools/pnacl-llc/CMakeLists.txt	View		1 chunk	+2 lines, -4 lines	0 comments	Download
A +	tools/pnacl-llc/LLVMBuild.txt	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	tools/pnacl-llc/Makefile	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	tools/pnacl-llc/SRPCStreamer.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	tools/pnacl-llc/SRPCStreamer.cpp	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	tools/pnacl-llc/nacl_file.cpp	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	tools/pnacl-llc/pnacl-llc.cpp	View	1 2	8 chunks	+5 lines, -90 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

eliben

First step in having our own llc-like driver for translation. This just copies over llc ...

7 years, 7 months ago (2013-05-15 15:51:08 UTC) #1

Mark Seaborn

https://codereview.chromium.org/14604011/diff/1/tools/pnacl-llc/pnacl-llc.cpp File tools/pnacl-llc/pnacl-llc.cpp (right): https://codereview.chromium.org/14604011/diff/1/tools/pnacl-llc/pnacl-llc.cpp#newcode88 tools/pnacl-llc/pnacl-llc.cpp:88: // @LOCALMOD-BEGIN Should these @LOCALMOD comments be removed too?

7 years, 7 months ago (2013-05-15 16:20:08 UTC) #2

jvoung (off chromium)

https://codereview.chromium.org/14604011/diff/1/tools/pnacl-llc/Makefile File tools/pnacl-llc/Makefile (right): https://codereview.chromium.org/14604011/diff/1/tools/pnacl-llc/Makefile#newcode11 tools/pnacl-llc/Makefile:11: TOOLNAME := llc toolname? https://codereview.chromium.org/14604011/diff/1/tools/pnacl-llc/pnacl-llc.cpp File tools/pnacl-llc/pnacl-llc.cpp (right): https://codereview.chromium.org/14604011/diff/1/tools/pnacl-llc/pnacl-llc.cpp#newcode19 ...

7 years, 7 months ago (2013-05-15 16:56:06 UTC) #3

eliben

7 years, 7 months ago (2013-05-15 18:01:18 UTC) #4

jvoung (off chromium)

lgtm https://codereview.chromium.org/14604011/diff/6001/tools/pnacl-llc/pnacl-llc.cpp File tools/pnacl-llc/pnacl-llc.cpp (right): https://codereview.chromium.org/14604011/diff/6001/tools/pnacl-llc/pnacl-llc.cpp#newcode216 tools/pnacl-llc/pnacl-llc.cpp:216: // @LOCALMOD-BEGIN dangling LOCALMOD-BEGIN?

7 years, 7 months ago (2013-05-15 18:10:20 UTC) #5

eliben

https://codereview.chromium.org/14604011/diff/6001/tools/pnacl-llc/pnacl-llc.cpp File tools/pnacl-llc/pnacl-llc.cpp (right): https://codereview.chromium.org/14604011/diff/6001/tools/pnacl-llc/pnacl-llc.cpp#newcode216 tools/pnacl-llc/pnacl-llc.cpp:216: // @LOCALMOD-BEGIN On 2013/05/15 18:10:21, jvoung (cr) wrote: > ...

7 years, 7 months ago (2013-05-15 18:13:33 UTC) #6

eliben

7 years, 7 months ago (2013-05-15 18:13:47 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 manually as r28aeda4 (presubmit successful).

Expand Messages | Collapse Messages