Chromium Code Reviews
Help | Chromium Project | Sign in
(68)

Issue 146040: Following the style guide, replace the overloaded operator==... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by wtc
Modified:
4 years ago
Reviewers:
eroman
CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium
Visibility:
Public.

Description

Following the style guide, replace the overloaded operator== with the Equals method. R=eroman BUG=http://crbug.com/318 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19056

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/base/x509_certificate.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
wtc
When I doublechecked the declaration order recommended by the Style Guide, I found this: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Operator_Overloading
5 years, 11 months ago (2009-06-23 18:04:35 UTC) #1
eroman
5 years, 11 months ago (2009-06-23 18:47:02 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be