Issue 146040: Following the style guide, replace the overloaded operator==...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 146040: Following the style guide, replace the overloaded operator==... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by wtc

Modified:
2 years, 11 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com, darin, willchan

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

    Following the style guide, replace the overloaded operator==

with the Equals method.

R=eroman

BUG=http://crbug.com/318

TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19056

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Lint	Patch
	M	net/base/x509_certificate.h	View		1 chunk	+1 line, -1 line	0 comments	0 errors	Download
	M	net/http/http_network_transaction.cc	View		1 chunk	+1 line, -1 line	0 comments	0 errors	Download

Trybot results:

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

wtc

When I doublechecked the declaration order recommended by the Style Guide, I found this: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Operator_Overloading

4 years, 10 months ago #1

lgtm

Expand All Messages | Collapse All Messages