Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1460393003: [es6] Fix parsing of 'yield' in function and generator expressions (Closed)

Created:
5 years, 1 month ago by adamk
Modified:
5 years, 1 month ago
Reviewers:
wingo, Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Fix parsing of 'yield' in function and generator expressions In a function expression, 'yield' is allowed, even if the expression occurs inside a generator. Similarly, even in a non-generator, a generator expression's name must not be 'yield'. BUG=v8:3983 LOG=n Committed: https://crrev.com/2ea7f3c8690e51e15147493b468a9837ab980bf3 Cr-Commit-Position: refs/heads/master@{#32188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -21 lines) Patch
M src/preparser.h View 3 chunks +19 lines, -9 lines 0 comments Download
M test/cctest/test-parsing.cc View 4 chunks +19 lines, -3 lines 0 comments Download
M test/mjsunit/es6/generators-parsing.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
5 years, 1 month ago (2015-11-21 00:48:11 UTC) #2
Dan Ehrenberg
lgtm
5 years, 1 month ago (2015-11-23 19:48:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460393003/1
5 years, 1 month ago (2015-11-23 21:00:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 21:34:03 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 21:34:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ea7f3c8690e51e15147493b468a9837ab980bf3
Cr-Commit-Position: refs/heads/master@{#32188}

Powered by Google App Engine
This is Rietveld 408576698