Fix crash in ClientSocketPoolBase.

Fix crash in ClientSocketPoolBase.
If a ConnectingSocket fails, we need to try to process a pending request.
BUG=http://crbug.com/14814
TEST=See bug for repro steps.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19067

[eroman, 2009-06-23 21:13:45]

lgtm

http://codereview.chromium.org/146037/diff/1/2
File net/socket/tcp_client_socket_pool.cc (right):

http://codereview.chromium.org/146037/diff/1/2#newcode213
Line 213: void ClientSocketPoolBase::CancelRequest(const std::string&
group_name,
doesn't |handle| already contain the groupname?

http://codereview.chromium.org/146037/diff/1/4
File net/socket/tcp_client_socket_pool_unittest.cc (right):

http://codereview.chromium.org/146037/diff/1/4#newcode604
Line 604: scoped_ptr<TestSocketRequest> reqs[kMaxSocketsPerGroup*2 + 1];
nit: space between binary operators.

[willchan no longer on Chromium, 2009-06-23 21:59:38]

Thanks for the review.

http://codereview.chromium.org/146037/diff/1/2
File net/socket/tcp_client_socket_pool.cc (right):

http://codereview.chromium.org/146037/diff/1/2#newcode213
Line 213: void ClientSocketPoolBase::CancelRequest(const std::string&
group_name,
On 2009/06/23 21:13:45, eroman wrote:
> doesn't |handle| already contain the groupname?

Yes.  I think at some point I thought it was better to be explicit about the
group_name and pass it in directly rather than via ClientSocketHandle.  I don't
know why I felt like that before, but I don't feel strongly either way.  In any
case, I won't address it in this changelist.  If you'd like, I can follow it up
after this one (and after my other changelist that breaks ClientSocketPoolBase
out of this file).

http://codereview.chromium.org/146037/diff/1/4
File net/socket/tcp_client_socket_pool_unittest.cc (right):

http://codereview.chromium.org/146037/diff/1/4#newcode604
Line 604: scoped_ptr<TestSocketRequest> reqs[kMaxSocketsPerGroup*2 + 1];
On 2009/06/23 21:13:45, eroman wrote:
> nit: space between binary operators.

Done.