Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1460353002:
Remove last use of the toLocalFrameTemporary macro. (Closed)
|
Created:
5 years, 1 month ago by dcheng Modified:
5 years, 1 month ago Reviewers:
lfg CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, site-isolation-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove last use of the toLocalFrameTemporary macro.
The frame tree supports remote frames now.
BUG=none
Committed: https://crrev.com/a01e0098d4383cf2cffe5903c573a785f1c835c1
Cr-Commit-Position: refs/heads/master@{#361002}
Patch Set 1 #
Total comments: 2
Patch Set 2 : remove FIXME #
Messages
Total messages: 21 (9 generated)
dcheng@chromium.org changed reviewers: + lfg@chromium.org
lgtm
The CQ bit was checked by dcheng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460353002/1
https://codereview.chromium.org/1460353002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/dom/Document.cpp (left): https://codereview.chromium.org/1460353002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/dom/Document.cpp:993: // FIXME(kenrb): the downcast can be removed when the FrameTree supports RemoteFrames. remove the FIXME?
The CQ bit was unchecked by lfg@chromium.org
The CQ bit was checked by dcheng@chromium.org
https://codereview.chromium.org/1460353002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/dom/Document.cpp (left): https://codereview.chromium.org/1460353002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/dom/Document.cpp:993: // FIXME(kenrb): the downcast can be removed when the FrameTree supports RemoteFrames. On 2015/11/20 at 21:20:38, sof wrote: > remove the FIXME? Oops, missed this when I was pulling cleanup patches out of another patch. Done.
The patchset sent to the CQ was uploaded after l-g-t-m from lfg@chromium.org Link to the patchset: https://codereview.chromium.org/1460353002/#ps20001 (title: "remove FIXME")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460353002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dcheng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460353002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by dcheng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460353002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a01e0098d4383cf2cffe5903c573a785f1c835c1 Cr-Commit-Position: refs/heads/master@{#361002} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
