Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 146033003: Land Recent QUIC Changes. (Closed)

Created:
6 years, 10 months ago by ramant (doing other things)
Modified:
6 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng, Jana
Visibility:
Public.

Description

Land Recent QUIC Changes. Cleanup: remove BlockedWriterInterface from QuicPacketWriter. No behavior changes. Merge internal change: 60499316 https://codereview.chromium.org/135363006/ Properly trigger OnCanWrite processing from PacketDroppingTestWriter. Re-enable the LargePostWithPacketLossAndBlockedSocket test. Testing only. Dialing back the loss from 30% to 10% seems to have stabilized the test. Merge internal change: 60479729 https://codereview.chromium.org/131503016/ Use LOG_IF instead of LOG_IF_FIRST_N in a few places, as per avd's suggestion. Merge internal change: 60382807 https://codereview.chromium.org/149163004/ Change the default RTT from 60ms to 100ms, which is more typical of internal server's. Merge internal change: 60366147 https://codereview.chromium.org/146583006/ Remove an impossible check in QuicConnection for when a packet is retransmitted before it is sent. Updating the tests also found and fixed an edge case where a truncated ack could cause the SentPacketManager to raise the high water mark above a pending packet. Merge internal change: 60169343 https://codereview.chromium.org/145123003/ Export primary insecure and secure QUIC config id via internal server status pages. Merge internal change: 60108488 https://codereview.chromium.org/137423015/ Export SCIDs, QUIC secret seed names and orbits to varz. Merge internal change: 60107113 https://codereview.chromium.org/144033006/ Refactor QuicConnection to use explicit notification for getting onto the write blocked list. Remove the PacketWriter interface from QuicDispatcher. Merge internal change: 60103466 Fix build. Build got broken by a race between presubmit tests and me editing the file that was in the process of being submitted. :( Merge internal change: 60104577 https://codereview.chromium.org/149263002/ Remove the word Payload from AddFrame methods in QUIC framer. Merge internal change: 60101552 https://codereview.chromium.org/131513022/ Fixes QUIC's Cubic sender to use correct alpha when in Reno mode. Merge internal change: 60088487 https://codereview.chromium.org/136453013/ Add DFATALs to QuicFramer branches where packet creation fails. Merge internal change: 60077767 https://codereview.chromium.org/148073002/ Fix a QUIC bug where previously undecryptable packets were not decrypted before sending out an ack when the encryption level changed. Merge internal change: 60051502 Added logging for all frame types. Added code to dump frames and packet_headers. Changes to make QuicHttpStreamTest work. https://codereview.chromium.org/144063012/ R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247827

Patch Set 1 #

Patch Set 2 : fix compiler error #

Patch Set 3 : Upload one more time #

Patch Set 4 : Fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+596 lines, -519 lines) Patch
M net/quic/congestion_control/cubic.cc View 1 2 3 3 chunks +35 lines, -11 lines 0 comments Download
M net/quic/congestion_control/cubic_test.cc View 1 2 3 5 chunks +18 lines, -17 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 4 chunks +16 lines, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 5 chunks +25 lines, -0 lines 0 comments Download
M net/quic/quic_client_session_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_connection.h View 6 chunks +27 lines, -23 lines 0 comments Download
M net/quic/quic_connection.cc View 11 chunks +78 lines, -75 lines 0 comments Download
M net/quic/quic_connection_test.cc View 24 chunks +31 lines, -31 lines 0 comments Download
M net/quic/quic_default_packet_writer.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/quic_default_packet_writer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_framer.h View 1 chunk +12 lines, -14 lines 0 comments Download
M net/quic/quic_framer.cc View 11 chunks +25 lines, -13 lines 0 comments Download
M net/quic/quic_framer_test.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_packet_writer.h View 2 chunks +1 line, -3 lines 0 comments Download
M net/quic/quic_protocol.h View 4 chunks +15 lines, -0 lines 0 comments Download
M net/quic/quic_protocol.cc View 3 chunks +78 lines, -7 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 6 chunks +12 lines, -27 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 8 chunks +33 lines, -150 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.h View 1 chunk +8 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 8 chunks +38 lines, -15 lines 0 comments Download
M net/tools/quic/quic_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_default_packet_writer.h View 2 chunks +1 line, -3 lines 0 comments Download
M net/tools/quic/quic_default_packet_writer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 5 chunks +9 lines, -18 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 4 chunks +20 lines, -43 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/tools/quic/quic_packet_writer_wrapper.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_packet_writer_wrapper.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 8 chunks +9 lines, -16 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.h View 4 chunks +14 lines, -6 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.cc View 7 chunks +13 lines, -10 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ramant (doing other things)
6 years, 10 months ago (2014-01-29 04:31:17 UTC) #1
ramant (doing other things)
Hi Jana and Ryan, Made a small changed to cubic.cc to use double instead of ...
6 years, 10 months ago (2014-01-29 17:51:07 UTC) #2
Ryan Hamilton
lgtm
6 years, 10 months ago (2014-01-29 19:29:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/146033003/80001
6 years, 10 months ago (2014-01-29 20:24:47 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=253741
6 years, 10 months ago (2014-01-29 22:42:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/146033003/80001
6 years, 10 months ago (2014-01-29 22:50:53 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 04:03:09 UTC) #7
Message was sent while issue was closed.
Change committed as 247827

Powered by Google App Engine
This is Rietveld 408576698