Add layout states to DocumentLifecycle state machine

Add layout states to DocumentLifecycle state machine

This CL adds a number of layout-related states to the DocumentLifecycle state
machine. Currently, we're using these states to ASSERT that we're making valid
transitions. Eventually, we'll switch over to these states as the source of
truth.

R=ojan@chromium.org
BUG=341627
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166765

[ojan, 2014-02-07 02:08:46]

lgtm

https://codereview.chromium.org/146023008/diff/1/Source/core/dom/DocumentLife...
File Source/core/dom/DocumentLifecycle.cpp (right):

https://codereview.chromium.org/146023008/diff/1/Source/core/dom/DocumentLife...
Source/core/dom/DocumentLifecycle.cpp:83: if (m_state == Disposed) {
Nit: should these if-statements be a switch statement? Not sure it really
matters either way.

https://codereview.chromium.org/146023008/diff/1/Source/core/dom/DocumentLife...
Source/core/dom/DocumentLifecycle.cpp:99: // We can redundant arrive in the
style clean state.
This is a little weird to me. I guess Document::recalcStyle doesn't early return
if it doesn't need recalc.

https://codereview.chromium.org/146023008/diff/1/Source/core/dom/DocumentLife...
Source/core/dom/DocumentLifecycle.cpp:133: // We can redundant arrive in the
layout clean state.
Ditto...FrameView::layout doesn't early return either.

[abarth-chromium, 2014-02-07 02:18:50]

https://codereview.chromium.org/146023008/diff/1/Source/core/dom/DocumentLife...
File Source/core/dom/DocumentLifecycle.cpp (right):

https://codereview.chromium.org/146023008/diff/1/Source/core/dom/DocumentLife...
Source/core/dom/DocumentLifecycle.cpp:99: // We can redundant arrive in the
style clean state.
On 2014/02/07 02:08:46, ojan wrote:
> This is a little weird to me. I guess Document::recalcStyle doesn't early
return
> if it doesn't need recalc.

Yeah.  It just doesn't do any work.

https://codereview.chromium.org/146023008/diff/1/Source/core/dom/DocumentLife...
Source/core/dom/DocumentLifecycle.cpp:133: // We can redundant arrive in the
layout clean state.
On 2014/02/07 02:08:46, ojan wrote:
> Ditto...FrameView::layout doesn't early return either.

It's because layout is recursive.  As you walk up the recursion, everything is
already clean.

[abarth-chromium, 2014-02-07 02:18:56]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-02-07 02:19:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/146023008/1

[commit-bot: I haz the power, 2014-02-07 05:22:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-07 05:22:21]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[abarth-chromium, 2014-02-07 06:44:01]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-02-07 06:44:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/146023008/1

[abarth-chromium, 2014-02-07 07:13:23]

The CQ bit was unchecked by abarth@chromium.org

[abarth-chromium, 2014-02-07 07:16:09]

Looks like there's a flaky ASSERT from the layout call in
Document::implicitClose.  I saw that locally, but it seemed to go away.  It's
probably timing dependent.

[abarth-chromium, 2014-02-08 06:47:32]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-02-08 06:47:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/146023008/320001

[commit-bot: I haz the power, 2014-02-08 09:05:16]

Change committed as 166765