Issue 146023004: inline api getters in crankshaft

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146023004: inline api getters in crankshaft (Closed)

Created:
6 years, 10 months ago by dcarney

Modified:
6 years, 10 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

inline api getters in crankshaft R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19110

Patch Set 7 : rebase #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+161 lines, -59 lines)			Patch
M	src/hydrogen.h	View	1 2 3 4 5 6	3 chunks	+17 lines, -5 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2 3 4 5 6	8 chunks	+100 lines, -39 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 2 3 4 5	3 chunks	+44 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

https://codereview.chromium.org/146023004/diff/140001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/146023004/diff/140001/src/hydrogen.cc#newcode7610 src/hydrogen.cc:7610: HValue * receiver, Remove space between HValue and * ...

6 years, 10 months ago (2014-02-04 13:25:31 UTC) #1

dcarney

6 years, 10 months ago (2014-02-05 15:52:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #7 manually as r19110 (presubmit successful).

Expand Messages | Collapse Messages

Issue 146023004: inline api getters in crankshaft (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : rebase #

Messages