Password manager now ignores autocomplete='off' by default; user may specify a flag that says other…

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <algorithm>
 #include <iterator>
 #include <map>
 #include <set>
@@ skipping 1929 matching lines @@
     MULTI_VALUE_TYPE(kOriginChipChoices)
   },
   {
     "search-button-in-omnibox",
     IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_NAME,
     IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_DESCRIPTION,
     kOsCrOS | kOsMac | kOsWin,
     MULTI_VALUE_TYPE(kSearchButtonInOmniboxChoices)
   },
   {
-    "enable-ignore-autocomplete-off",
-    IDS_FLAGS_ENABLE_IGNORE_AUTOCOMPLETE_OFF_NAME,
-    IDS_FLAGS_ENABLE_IGNORE_AUTOCOMPLETE_OFF_DESCRIPTION,
+    "do-not-ignore-autocomplete-off",

[Patrick Dubroy, 2014/01/24 16:39:10]

I know it sounds a bit confusing, but "disable" is usually what we'd use for
these sorts of flags. I'd go with that.

[jww, 2014/01/24 18:01:14]

Done.

+    IDS_FLAGS_DO_NOT_IGNORE_AUTOCOMPLETE_OFF_NAME,
+    IDS_FLAGS_DO_NOT_IGNORE_AUTOCOMPLETE_OFF_DESCRIPTION,
     kOsAll,
-    SINGLE_VALUE_TYPE(autofill::switches::kEnableIgnoreAutocompleteOff)
+    SINGLE_VALUE_TYPE(autofill::switches::kDoNotIgnoreAutocompleteOff)
   },
 #if defined(USE_AURA) || defined(OS_WIN)
   {
     "enable-save-password-bubble",
     IDS_FLAGS_ENABLE_PASSWORD_BUBBLE_NAME,
     IDS_FLAGS_ENABLE_PASSWORD_BUBBLE_DESCRIPTION,
     kOsWin | kOsCrOS,
     SINGLE_VALUE_TYPE(switches::kEnableSavePasswordBubble)
   },
 #endif
@@ skipping 526 matching lines @@
 }
 
 const Experiment* GetExperiments(size_t* count) {
   *count = num_experiments;
   return experiments;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags