Propagate types of final/const top-level variables and fields.

Propagate types of final/const top-level variables and fields.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23001

Committed: https://github.com/dart-lang/sdk/commit/8c324a5b8d95ae280a1de462c75ff09d6364f17d

[scheglov, 2015-11-21 04:40:04]

Description was changed from

==========
Propagate types of final/const top-level variables and fields.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Propagate types of final/const top-level variables and fields.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23001
==========

[Brian Wilkerson, 2015-11-21 15:11:26]

LGTM

https://codereview.chromium.org/1460213005/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1460213005/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:403: final ResultDescriptor<bool>
READY_RESOLVED_UNIT10 =
Should we update the name to match the comment, or is the comment wrong?
(Likewise for READY_RESOLVED_UNIT9.)

https://codereview.chromium.org/1460213005/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:3736: // Re-resolve the variable's
initializer so that the inferred types
"inferred" --> "propagated"?

https://codereview.chromium.org/1460213005/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:3754: DartType newType =
initializer.bestType;
I think this wants to be the propagatedType, not the best type. Otherwise we
could end up recording the static type as the propagated type, which I don't
think we want to do.

[scheglov, 2015-11-21 17:37:23]

https://codereview.chromium.org/1460213005/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1460213005/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:403: final ResultDescriptor<bool>
READY_RESOLVED_UNIT10 =
On 2015/11/21 15:11:26, Brian Wilkerson wrote:
> Should we update the name to match the comment, or is the comment wrong?
> (Likewise for READY_RESOLVED_UNIT9.)

Done.

https://codereview.chromium.org/1460213005/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:3754: DartType newType =
initializer.bestType;
On 2015/11/21 15:11:26, Brian Wilkerson wrote:
> I think this wants to be the propagatedType, not the best type. Otherwise we
> could end up recording the static type as the propagated type, which I don't
> think we want to do.

Actually in the most cases the initializer is a value with a static type only,
for example:

final a = 42;

Here "42" has only static type - int.
And yes, we record it as a propagated type.


But if have also:

final b = a;

Then "a" here has staticType==dynamic and propagatedType==int.
So, we use the "bestType", which is "int".

[scheglov, 2015-11-21 17:40:42]

Committed patchset #2 (id:20001) manually as
8c324a5b8d95ae280a1de462c75ff09d6364f17d (presubmit successful).