Issue 1460213002: Add default file for command line arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1460213002: Add default file for command line arguments. (Closed)

Created:
5 years, 1 month ago by qsr

Modified:
5 years, 1 month ago

Reviewers:
ppi

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add default file for command line arguments. Mojo Shell on Android will now look at /data/local/tmp/{package_name}.cmd for default arguments. This file must contain one argument per line. Moreover, this file must not be writeable by the application to prevent other application modifying it. R=ppi@chromium.org BUG=Fixes https://github.com/domokit/mojo/issues/550 Committed: https://chromium.googlesource.com/external/mojo/+/10bef82afdc342c0118564d8afb35c9c2f83313e

Patch Set 1 #

Patch Set 2 : Follow live discussion #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -18 lines)			Patch
	M	mojo/devtools/common/devtoolslib/android_shell.py	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	shell/android/apk/src/org/chromium/mojo/shell/ShellService.java	View	1	6 chunks	+38 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ppi

lgtm please double-check if the indents are `git cl format` happy.

5 years, 1 month ago (2015-11-20 15:12:46 UTC) #2

qsr

5 years, 1 month ago (2015-11-20 15:15:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
10bef82afdc342c0118564d8afb35c9c2f83313e (presubmit successful).

Expand Messages | Collapse Messages