Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: scripts/slave/recipe_util.py

Issue 14602020: Add an AOSP builder recipe. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_util.py
diff --git a/scripts/slave/recipe_util.py b/scripts/slave/recipe_util.py
index a67cd054e54e282c524e3693c82009247c347810..d4222fd87af8b14a43604614e33b91f598ab25c9 100644
--- a/scripts/slave/recipe_util.py
+++ b/scripts/slave/recipe_util.py
@@ -185,6 +185,15 @@ class PropertyPlaceholder(object):
pass
PropertyPlaceholder = PropertyPlaceholder()
+class DelayedEvalParameter(object):
mkosiba (inactive) 2013/05/07 13:30:19 don't need this
+ """DelayedEvalParameter allows for commands to be supplied with arguments
+ that are evaluated/executed just before the command is run.
+
+ This is useful mostly when the command depends on files checked into the
+ source folder."""
+
+ def cmd(self):
+ pass
def _url_method(name):
"""Returns a shortcut static method which functions like os.path.join and uses
@@ -233,7 +242,7 @@ class Steps(object):
return GCLIENT_COMMON_SPECS[solution_name](self)
@staticmethod
- def step(name, cmd, add_properties=False, **kwargs):
+ def step(name, cmd, cwd=None, add_properties=False, **kwargs):
"""Returns a step dictionary which is compatible with annotator.py. Uses
PropertyPlaceholder as a stand-in for build-properties and
factory-properties so that annotated_run can fill them in after the recipe
@@ -244,6 +253,8 @@ class Steps(object):
cmd += [PropertyPlaceholder]
ret = kwargs
ret.update({'name': name, 'cmd': cmd})
+ if cwd:
+ ret.update({'cwd': cwd})
agable 2013/05/06 17:53:11 This is already handled by **kwargs
mkosiba (inactive) 2013/05/07 13:30:19 Done.
return ret
def apply_issue_step(self, root_pieces=None):

Powered by Google App Engine
This is Rietveld 408576698