Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1460193002: Remove usage of deprecated APIs from assembler tests (Closed)

Created:
5 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
5 years, 1 month ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove usage of deprecated APIs from assembler tests BUG=4134 R=epertoso@chromium.org LOG=n Committed: https://crrev.com/6e13300c19f6241ae6405f70a7ef993bc47b3623 Cr-Commit-Position: refs/heads/master@{#32137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -15 lines) Patch
M test/cctest/test-assembler-arm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 5 chunks +13 lines, -7 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-ppc.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 5 chunks +19 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 1 month ago (2015-11-20 08:56:49 UTC) #1
epertoso
lgtm
5 years, 1 month ago (2015-11-20 09:21:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460193002/1
5 years, 1 month ago (2015-11-20 09:28:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 09:29:35 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 09:30:32 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6e13300c19f6241ae6405f70a7ef993bc47b3623
Cr-Commit-Position: refs/heads/master@{#32137}

Powered by Google App Engine
This is Rietveld 408576698