Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 1460183003: PPC: [turbofan]: Implement tail calls with more callee than caller parameters (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan]: Implement tail calls with more callee than caller parameters Port c6d310da4d86ce2d8178a49f4d34b66ad6143432 Original commit message: * Adds a PrepareForTailCall instruction that bumps the stack in the case that the number of parameters passed to the callee causes the stack to exceed the calleer's frame size. * Uses the gap resolver to move the saved caller return address and frame pointer to the approprate location in the tail-called frame. R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4076 LOG=n Committed: https://crrev.com/1d1557d8fded51c323e01b4ca5e36be2861bee3b Cr-Commit-Position: refs/heads/master@{#32183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 2 chunks +24 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 1 month ago (2015-11-20 23:46:03 UTC) #1
michael_dawson
On 2015/11/20 23:46:03, mtbrandyberry wrote: lgtm
5 years ago (2015-11-23 14:22:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460183003/1
5 years ago (2015-11-23 14:39:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-23 15:32:09 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-23 15:32:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d1557d8fded51c323e01b4ca5e36be2861bee3b
Cr-Commit-Position: refs/heads/master@{#32183}

Powered by Google App Engine
This is Rietveld 408576698